From 58cc6cdbe0a0553a8e4319de12132e82d8bb85df Mon Sep 17 00:00:00 2001 From: Eugene Triguba Date: Mon, 11 Mar 2024 18:56:21 -0400 Subject: Add support for sql server --- .env.mssql | 6 ++ .github/workflows/test.yml | 1 + CHANGELOG.md | 6 ++ README.md | 5 +- docker-compose.mssql.yml | 11 +++ go.mod | 3 + go.sum | 34 +++++++ internal/repositories/migration_db_repo.go | 22 +++-- internal/repositories/migration_db_repo_test.go | 1 + internal/storage/db.go | 5 +- internal/storage/mssql.go | 78 +++++++++++++++ internal/storage/mssql_test.go | 123 ++++++++++++++++++++++++ 12 files changed, 286 insertions(+), 9 deletions(-) create mode 100644 .env.mssql create mode 100644 docker-compose.mssql.yml create mode 100644 internal/storage/mssql.go create mode 100644 internal/storage/mssql_test.go diff --git a/.env.mssql b/.env.mssql new file mode 100644 index 0000000..94a5f0c --- /dev/null +++ b/.env.mssql @@ -0,0 +1,6 @@ +BOLT_DB_CONN_DBNAME=master +BOLT_DB_CONN_HOST=localhost +BOLT_DB_CONN_PORT=4003 +BOLT_DB_CONN_USER=sa +BOLT_DB_CONN_PASSWORD=testPASS123.? +BOLT_DB_CONN_DRIVER=mssql diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 08763d8..565aa80 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,6 +14,7 @@ jobs: db: - {name: postgresql} - {name: mysql} + - {name: mssql} steps: - name: Checkout Source Code uses: actions/checkout@v4 diff --git a/CHANGELOG.md b/CHANGELOG.md index 41695e6..964d621 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Added + +- Support for Microsoft SQL Server. + ## [0.5.0] - 2024-03-10 ### Added diff --git a/README.md b/README.md index d0f9de9..88e195c 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Bolt is a command-line tool designed to simplify and streamline your database migration process. 🌟 Key Features: -- **SQL-Powered Flexibility**: 🧩 - Write your migration scripts in plain SQL. This gives you the full power and familiarity of SQL. +- **SQL-Powered Flexibility**: 🧩 - Write your migration scripts in plain SQL. - **Bidirectional Migrations**: 🔀 - With support for both 'up' (migrating) and 'down' (downgrading) migrations, Bolt provides complete control over your database versions. @@ -247,6 +247,7 @@ In your `upgrade.sql` or `downgrade.sql`, add the following line as the first li - PostgreSQL - MySQL +- Microsoft SQL Server ### Configuration @@ -287,7 +288,7 @@ password = # The name of the database within your DBMS. dbname = # The name of the database driver to use to connect to -# the database. Either "postgresql" or "mysql". +# the database. Either "postgresql", "mysql", or "mssql". driver = ``` diff --git a/docker-compose.mssql.yml b/docker-compose.mssql.yml new file mode 100644 index 0000000..144a00a --- /dev/null +++ b/docker-compose.mssql.yml @@ -0,0 +1,11 @@ +version: "3.8" + +services: + mssql_db: + image: mcr.microsoft.com/mssql/server:2022-latest + container_name: bolt_mssql_db + ports: + - "${BOLT_DB_CONN_PORT:?err}:1433" + environment: + - ACCEPT_EULA=Y + - MSSQL_SA_PASSWORD=${BOLT_DB_CONN_PASSWORD:?err} diff --git a/go.mod b/go.mod index 5b54f95..f650e26 100644 --- a/go.mod +++ b/go.mod @@ -13,10 +13,13 @@ require ( require ( filippo.io/edwards25519 v1.1.0 // indirect + github.com/golang-sql/civil v0.0.0-20220223132316-b832511892a9 // indirect + github.com/golang-sql/sqlexp v0.1.0 // indirect github.com/google/go-cmp v0.6.0 // indirect github.com/jackc/pgpassfile v1.0.0 // indirect github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a // indirect github.com/jackc/puddle/v2 v2.2.1 // indirect + github.com/microsoft/go-mssqldb v1.7.0 // indirect golang.org/x/crypto v0.20.0 // indirect golang.org/x/sync v0.1.0 // indirect golang.org/x/text v0.14.0 // indirect diff --git a/go.sum b/go.sum index 76bd8d9..ac6da7d 100644 --- a/go.sum +++ b/go.sum @@ -1,14 +1,26 @@ filippo.io/edwards25519 v1.1.0 h1:FNf4tywRC1HmFuKW5xopWpigGjJKiJSV0Cqo0cJWDaA= filippo.io/edwards25519 v1.1.0/go.mod h1:BxyFTGdWcka3PhytdK4V28tE5sGfRvvvRV7EaN4VDT4= +github.com/Azure/azure-sdk-for-go/sdk/azcore v0.19.0/go.mod h1:h6H6c8enJmmocHUbLiiGY6sx7f9i+X3m1CHdd5c6Rdw= +github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.11.0/go.mod h1:HcM1YX14R7CJcghJGOYCgdezslRSVzqwLf/q+4Y2r/0= +github.com/Azure/azure-sdk-for-go/sdk/internal v0.7.0/go.mod h1:yqy467j36fJxcRV2TzfVZ1pCb5vxm4BtZPUdYWe/Xo8= github.com/BurntSushi/toml v1.3.2 h1:o7IhLm0Msx3BaB+n3Ag7L8EVlByGnpq14C4YWiu/gL8= github.com/BurntSushi/toml v1.3.2/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/denisenkom/go-mssqldb v0.12.3 h1:pBSGx9Tq67pBOTLmxNuirNTeB8Vjmf886Kx+8Y+8shw= +github.com/denisenkom/go-mssqldb v0.12.3/go.mod h1:k0mtMFOnU+AihqFxPMiF05rtiDrorD1Vrm1KEz5hxDo= +github.com/dnaeon/go-vcr v1.2.0/go.mod h1:R4UdLID7HZT3taECzJs4YgbbH6PIGXB6W/sc5OLb6RQ= github.com/eugenetriguba/checkmate v0.3.2 h1:vcALwpLLpt0FBxckjuobNFYtBLtlCT2p55Xk4p0SAhk= github.com/eugenetriguba/checkmate v0.3.2/go.mod h1:IY38Cl4zlNI1dg+wcDYwrbWZfJ9i2/ouWf8C0N8c/do= github.com/go-sql-driver/mysql v1.8.0 h1:UtktXaU2Nb64z/pLiGIxY4431SJ4/dR5cjMmlVHgnT4= github.com/go-sql-driver/mysql v1.8.0/go.mod h1:wEBSXgmK//2ZFJyE+qWnIsVGmvmEKlqwuVSjsCm7DZg= +github.com/golang-sql/civil v0.0.0-20190719163853-cb61b32ac6fe h1:lXe2qZdvpiX5WZkZR4hgp4KJVfY3nMkvmwbVkpv1rVY= +github.com/golang-sql/civil v0.0.0-20190719163853-cb61b32ac6fe/go.mod h1:8vg3r2VgvsThLBIFL93Qb5yWzgyZWhEmBwUJWevAkK0= +github.com/golang-sql/civil v0.0.0-20220223132316-b832511892a9 h1:au07oEsX2xN0ktxqI+Sida1w446QrXBRJ0nee3SNZlA= +github.com/golang-sql/civil v0.0.0-20220223132316-b832511892a9/go.mod h1:8vg3r2VgvsThLBIFL93Qb5yWzgyZWhEmBwUJWevAkK0= +github.com/golang-sql/sqlexp v0.1.0 h1:ZCD6MBpcuOVfGVqsEmY5/4FtYiKz6tSyUv9LPEDei6A= +github.com/golang-sql/sqlexp v0.1.0/go.mod h1:J4ad9Vo8ZCWQ2GMrC4UCQy1JpCbwU9m3EOqtpKwwwHI= github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI= github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= github.com/google/subcommands v1.2.0 h1:vWQspBTo2nEqTUFita5/KeEWlUL8kQObDFbub/EN9oE= @@ -23,6 +35,10 @@ github.com/jackc/puddle/v2 v2.2.1 h1:RhxXJtFG022u4ibrCSMSiu5aOq1i77R3OHKNJj77OAk github.com/jackc/puddle/v2 v2.2.1/go.mod h1:vriiEXHvEE654aYKXXjOvZM39qJ0q+azkZFrfEOc3H4= github.com/kelseyhightower/envconfig v1.4.0 h1:Im6hONhd3pLkfDFsbRgu68RDNkGF1r3dvMUtDTo2cv8= github.com/kelseyhightower/envconfig v1.4.0/go.mod h1:cccZRl6mQpaq41TPp5QxidR+Sa3axMbJDNb//FQX6Gg= +github.com/microsoft/go-mssqldb v1.7.0 h1:sgMPW0HA6Ihd37Yx0MzHyKD726C2kY/8KJsQtXHNaAs= +github.com/microsoft/go-mssqldb v1.7.0/go.mod h1:kOvZKUdrhhFQmxLZqbwUV0rHkNkZpthMITIb2Ko1IoA= +github.com/modocache/gover v0.0.0-20171022184752-b58185e213c5/go.mod h1:caMODM3PzxT8aQXRPkAt8xlV/e7d7w8GM5g0fa5F0D8= +github.com/pkg/browser v0.0.0-20180916011732-0a3d74bf9ce4/go.mod h1:4OwLy04Bl9Ef3GJJCoec+30X3LQs/0/m4HFRt/2LUSA= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= @@ -30,13 +46,31 @@ github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UV github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= github.com/stretchr/testify v1.8.1 h1:w7B6lhMri9wdJUVmEZPGGhZzrYTPvgJArz7wNPgYKsk= github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4= +golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= +golang.org/x/crypto v0.0.0-20201016220609-9e8e0b390897/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= +golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= golang.org/x/crypto v0.20.0 h1:jmAMJJZXr5KiCw05dfYK9QnqaqKLYXijU23lsEdcQqg= golang.org/x/crypto v0.20.0/go.mod h1:Xwo95rrVNIoSMx9wa1JroENMToLWn3RNVrTBpLHgZPQ= +golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= +golang.org/x/net v0.0.0-20210610132358-84b48f89b13b/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= +golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o= golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= +golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= +golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= +golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ= golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU= +golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= +gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ= gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= +gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA= gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= diff --git a/internal/repositories/migration_db_repo.go b/internal/repositories/migration_db_repo.go index 27644ae..e97349a 100644 --- a/internal/repositories/migration_db_repo.go +++ b/internal/repositories/migration_db_repo.go @@ -28,18 +28,28 @@ type migrationDBRepo struct { // operates on exists. If it is unable to create or confirm // the table exists, an error is returned. func NewMigrationDBRepo(db storage.DB) (MigrationDBRepo, error) { - _, err := db.Exec(` - CREATE TABLE IF NOT EXISTS bolt_migrations( - version CHARACTER(14) PRIMARY KEY NOT NULL - ); - `) + migrationTableExists, err := db.TableExists("bolt_migrations") if err != nil { return nil, fmt.Errorf( - "unable to create or confirm bolt_migrations database table exists: %w", + "unable to confirm bolt_migrations database table exists: %w", err, ) } + if !migrationTableExists { + _, err := db.Exec(` + CREATE TABLE bolt_migrations( + version CHARACTER(14) PRIMARY KEY NOT NULL + ); + `) + if err != nil { + return nil, fmt.Errorf( + "unable to create bolt_migrations database table: %w", + err, + ) + } + } + return &migrationDBRepo{db: db}, nil } diff --git a/internal/repositories/migration_db_repo_test.go b/internal/repositories/migration_db_repo_test.go index 2a316c9..9c5d824 100644 --- a/internal/repositories/migration_db_repo_test.go +++ b/internal/repositories/migration_db_repo_test.go @@ -245,6 +245,7 @@ func TestRevertWithTx_SuccessfullyReverted(t *testing.T) { t.Cleanup(func() { bolttest.DropTable(t, testdb, "tmp") }) + bolttest.DropTable(t, testdb, "tmp") _, err = testdb.Exec(`CREATE TABLE tmp(id INT NOT NULL PRIMARY KEY)`) assert.Nil(t, err) diff --git a/internal/storage/db.go b/internal/storage/db.go index 70c3344..12adc4c 100644 --- a/internal/storage/db.go +++ b/internal/storage/db.go @@ -8,14 +8,17 @@ import ( "github.com/eugenetriguba/bolt/internal/configloader" _ "github.com/go-sql-driver/mysql" _ "github.com/jackc/pgx/v5/stdlib" + _ "github.com/microsoft/go-mssqldb" ) var postgresqlDriverName = "postgresql" var mysqlDriverName = "mysql" +var mssqlDriverName = "mssql" var supportedDrivers = map[string]dbDriver{ postgresqlDriverName: {name: "pgx", adapter: PostgresqlAdapter{}}, mysqlDriverName: {name: "mysql", adapter: MySQLAdapter{}}, + mssqlDriverName: {name: "sqlserver", adapter: MSSQLAdapter{}}, } type dbDriver struct { @@ -30,7 +33,7 @@ var ( ErrUnableToConnect = errors.New("unable to open connection to database") ErrUnsupportedDriver = fmt.Errorf( "unsupported driver, supported drivers are %s", - []string{postgresqlDriverName, mysqlDriverName}, + []string{postgresqlDriverName, mysqlDriverName, mssqlDriverName}, ) ) diff --git a/internal/storage/mssql.go b/internal/storage/mssql.go new file mode 100644 index 0000000..a7fbead --- /dev/null +++ b/internal/storage/mssql.go @@ -0,0 +1,78 @@ +package storage + +import ( + "fmt" + "strconv" + "strings" + + "github.com/eugenetriguba/bolt/internal/configloader" + "github.com/microsoft/go-mssqldb/msdsn" +) + +type MSSQLAdapter struct{} + +func (m MSSQLAdapter) ConvertGenericPlaceholders( + query string, + argsCount int, +) string { + for i := 0; i <= argsCount; i++ { + placeholder := m.createPlaceholder(i + 1) + query = strings.Replace(query, "?", placeholder, 1) + } + return query +} + +func (m MSSQLAdapter) createPlaceholder(index int) string { + return fmt.Sprintf("@p%d", index) +} + +func (m MSSQLAdapter) TableExists( + executor sqlExecutor, + tableName string, +) (bool, error) { + var exists bool + err := executor.QueryRow(` + SELECT CASE WHEN EXISTS ( + SELECT * + FROM INFORMATION_SCHEMA.TABLES + WHERE TABLE_SCHEMA = 'dbo' + AND TABLE_NAME = @p1 + ) THEN 1 ELSE 0 END + `, tableName).Scan(&exists) + if err != nil { + return false, fmt.Errorf( + "unable to check if dbo.%s exists: %w", + tableName, + err, + ) + } + + return exists, nil +} + +func (m MSSQLAdapter) DatabaseName(executor sqlExecutor) (string, error) { + var name string + err := executor.QueryRow("SELECT DB_NAME();").Scan(&name) + if err != nil { + return "", fmt.Errorf("unable to retrieve database name: %w", err) + } + + return name, nil +} + +func (m MSSQLAdapter) CreateDSN(cfg configloader.ConnectionConfig) string { + port, err := strconv.ParseUint(cfg.Port, 10, 64) + if err != nil { + // Use default port if we can't parse it out. + // The mssql driver requires an int port to be passed. + port = 1433 + } + dsnCfg := msdsn.Config{ + Host: cfg.Host, + Port: port, + User: cfg.User, + Password: cfg.Password, + Database: cfg.DBName, + } + return dsnCfg.URL().String() +} diff --git a/internal/storage/mssql_test.go b/internal/storage/mssql_test.go new file mode 100644 index 0000000..400b210 --- /dev/null +++ b/internal/storage/mssql_test.go @@ -0,0 +1,123 @@ +//go:build mssql + +package storage_test + +import ( + "database/sql" + "fmt" + "testing" + + "github.com/eugenetriguba/bolt/internal/bolttest" + "github.com/eugenetriguba/bolt/internal/configloader" + "github.com/eugenetriguba/bolt/internal/storage" + "github.com/eugenetriguba/checkmate/assert" +) + +func TestConvertGenericPlaceholders(t *testing.T) { + type test struct { + query string + argCount int + expectedQuery string + } + + testCases := []test{ + { + query: "SELECT id, name FROM some_table;", + argCount: 0, + expectedQuery: "SELECT id, name FROM some_table;", + }, + { + query: "SELECT id, name FROM some_table WHERE id = ?;", + argCount: 1, + expectedQuery: "SELECT id, name FROM some_table WHERE id = @p1;", + }, + { + query: "SELECT id, name FROM some_table WHERE id = ? AND name = ?;", + argCount: 2, + expectedQuery: "SELECT id, name FROM some_table WHERE id = @p1 AND name = @p2;", + }, + } + for _, tc := range testCases { + adapter := storage.MSSQLAdapter{} + newQuery := adapter.ConvertGenericPlaceholders(tc.query, tc.argCount) + assert.Equal(t, newQuery, tc.expectedQuery) + } +} + +func TestTableExists(t *testing.T) { + cfg := bolttest.NewTestConnectionConfig() + adapter := storage.MSSQLAdapter{} + db, err := sql.Open("sqlserver", adapter.CreateDSN(cfg)) + assert.Nil(t, err) + t.Cleanup(func() { + _, err = db.Exec("DROP TABLE IF EXISTS tmp;") + assert.Nil(t, err) + assert.Nil(t, db.Close()) + }) + + exists, err := adapter.TableExists(db, "tmp") + assert.Nil(t, err) + assert.False(t, exists) + + _, err = db.Exec("CREATE TABLE tmp(id INT PRIMARY KEY);") + assert.Nil(t, err) + + exists, err = adapter.TableExists(db, "tmp") + assert.Nil(t, err) + assert.True(t, exists) +} + +func TestDatabaseName(t *testing.T) { + cfg := bolttest.NewTestConnectionConfig() + adapter := storage.MSSQLAdapter{} + db, err := sql.Open("sqlserver", adapter.CreateDSN(cfg)) + assert.Nil(t, err) + t.Cleanup(func() { + assert.Nil(t, db.Close()) + }) + + name, err := adapter.DatabaseName(db) + assert.Nil(t, err) + + assert.Equal(t, name, cfg.DBName) +} + +func TestCreateDSN(t *testing.T) { + cfg := configloader.ConnectionConfig{ + Driver: "mssql", + Host: "db1", + Port: "5432", + User: "testuser", + Password: "supersecretpassword", + DBName: "testdb", + } + adapter := storage.MSSQLAdapter{} + + cs := adapter.CreateDSN(cfg) + + expectedConnectionString := fmt.Sprintf( + "sqlserver://%s:%s@%s:%s?database=%s&dial+timeout=0&disableretry=false", + cfg.User, cfg.Password, cfg.Host, cfg.Port, cfg.DBName, + ) + assert.Equal(t, cs, expectedConnectionString) +} + +func TestCreateDSN_UnparsablePort(t *testing.T) { + cfg := configloader.ConnectionConfig{ + Driver: "mssql", + Host: "db1", + Port: "abc123", + User: "testuser", + Password: "supersecretpassword", + DBName: "testdb", + } + adapter := storage.MSSQLAdapter{} + + cs := adapter.CreateDSN(cfg) + + expectedConnectionString := fmt.Sprintf( + "sqlserver://%s:%s@%s:%s?database=%s&dial+timeout=0&disableretry=false", + cfg.User, cfg.Password, cfg.Host, "1433", cfg.DBName, + ) + assert.Equal(t, cs, expectedConnectionString) +} -- cgit v1.2.3