<feed xmlns='http://www.w3.org/2005/Atom'>
<title>cgit, branch lh/pretty-blob-view</title>
<subtitle>ui for git.eugenetriguba.com
</subtitle>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/'/>
<entry>
<title>ui-tree.c: cleanup printing of blobs in tree view</title>
<updated>2012-10-16T21:57:00+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-20T08:13:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=8a53f9dd6d86e7212c416df7d7c2c8598c1a6260'/>
<id>8a53f9dd6d86e7212c416df7d7c2c8598c1a6260</id>
<content type='text'>
Signed-off-by: Lars Hjemli &lt;larsh@hjemli.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lars Hjemli &lt;larsh@hjemli.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-repolist: Rename section-sort to repository-sort.</title>
<updated>2012-10-16T21:32:53+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-10-16T21:32:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=fdfb6a6d802d6b91061296eda9848d5819760d01'/>
<id>fdfb6a6d802d6b91061296eda9848d5819760d01</id>
<content type='text'>
Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>repo_config: do not let globals override repo settings</title>
<updated>2012-10-16T21:00:50+00:00</updated>
<author>
<name>Tobias Bieniek</name>
<email>Tobias.Bieniek@gmx.de</email>
</author>
<published>2012-04-18T10:32:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=8f40be229cf8ac7ecbf5e03e11098bad8e82e7e5'/>
<id>8f40be229cf8ac7ecbf5e03e11098bad8e82e7e5</id>
<content type='text'>
This makes it possible to activate the enable_commit_graph,
enable_log_filecount, and enable_log_linecount for individual
repositories, even if the global setting is "0" (default).

The commit that introduced the broken behavior was e189344, and the
commit message of that makes it clear that this wasn't the intended
behavior.

Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes it possible to activate the enable_commit_graph,
enable_log_filecount, and enable_log_linecount for individual
repositories, even if the global setting is "0" (default).

The commit that introduced the broken behavior was e189344, and the
commit message of that makes it clear that this wasn't the intended
behavior.

Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>README: times, they are a-changin</title>
<updated>2012-10-09T11:21:30+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-10-09T11:21:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=a9a6a205608c83125841f8f0b2aca07476cd2113'/>
<id>a9a6a205608c83125841f8f0b2aca07476cd2113</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>syntax-highlight: when the file has no extension, assume text</title>
<updated>2012-10-09T11:19:12+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-10-09T11:10:48+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=d14faf4424ae06ced696c15f205c85fe55b8e6e7'/>
<id>d14faf4424ae06ced696c15f205c85fe55b8e6e7</id>
<content type='text'>
There are 2 situations:
1- empty extension: assuming text is better than highlight
   producing no output because of a missing argument.
2- no extension at all: assuming text is better than setting
   the extension to the filename, which is what now happens.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are 2 situations:
1- empty extension: assuming text is better than highlight
   producing no output because of a missing argument.
2- no extension at all: assuming text is better than setting
   the extension to the filename, which is what now happens.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-repolist: do not use agefile if it's date could not be parsed</title>
<updated>2012-10-09T11:14:21+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-10-09T11:09:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=e52a5226b83dc5232adb7d9076cae3ad4b123df4'/>
<id>e52a5226b83dc5232adb7d9076cae3ad4b123df4</id>
<content type='text'>
Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "filters/syntax-highlighting.sh: work around highlight --force bug"</title>
<updated>2012-10-09T11:12:09+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-10-09T11:08:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=2ad9063cb53b55b1456c7d2ed08e6fb99d32ab78'/>
<id>2ad9063cb53b55b1456c7d2ed08e6fb99d32ab78</id>
<content type='text'>
This reverts commit f50be7fda0a7ab57009169dd5905fcbab8eb5166.

An update with the latest highlight landed in EPEL. This new version
doesn't have the --force bug, so the workaround can now be removed.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit f50be7fda0a7ab57009169dd5905fcbab8eb5166.

An update with the latest highlight landed in EPEL. This new version
doesn't have the --force bug, so the workaround can now be removed.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: add tag target to generate ctags</title>
<updated>2012-10-08T21:40:23+00:00</updated>
<author>
<name>Jamie Couture</name>
<email>jamie.couture@gmail.com</email>
</author>
<published>2012-10-08T17:12:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=6419c9b57c33a8a26d2775f01629f899afb61026'/>
<id>6419c9b57c33a8a26d2775f01629f899afb61026</id>
<content type='text'>
Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-repolist: Bold the currently viewed page.</title>
<updated>2012-10-08T21:29:29+00:00</updated>
<author>
<name>Jamie Couture</name>
<email>jamie.couture@gmail.com</email>
</author>
<published>2012-10-08T16:49:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=4675b91211fe3119a0def539521ac759b3fb57d0'/>
<id>4675b91211fe3119a0def539521ac759b3fb57d0</id>
<content type='text'>
Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>do not write outside heap buffer</title>
<updated>2012-10-02T02:03:47+00:00</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2012-04-23T20:06:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=61d4147ea2d58c9d129a084be13ccec6ae18b4d5'/>
<id>61d4147ea2d58c9d129a084be13ccec6ae18b4d5</id>
<content type='text'>
* parsing.c (substr): Handle tail &lt; head.

This started when I noticed some cgit segfaults on savannah.gnu.org.
Finding the offending URL/commit and then constructing a stand-alone
reproducer were far more time-consuming than writing the actual patch.

The problem arises with a commit like this, in which the user name
part of the "Author" field is empty:

    $ git log -1
    commit 6f3f41d73393278f3ede68a2cb1e7a2a23fa3421
    Author: &lt;T at h.or&gt;
    Date:   Mon Apr 23 22:29:16 2012 +0200

Here's what happens:

(this is due to buf=malloc(0); strncpy (buf, head, -1);
 where "head" may point to plenty of attacker-specified non-NUL bytes,
 so we can overwrite a zero-length heap buffer with arbitrary data)

 Invalid write of size 1
    at 0x4A09361: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)
  Address 0x4c718d0 is 0 bytes after a block of size 0 alloc'd
    at 0x4A0884D: malloc (vg_replace_malloc.c:263)
    by 0x455C85: xmalloc (wrapper.c:35)
    by 0x40894C: substr (parsing.c:60)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)

 Invalid write of size 1
    at 0x4A09400: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)
  Address 0x4c7192b is not stack'd, malloc'd or (recently) free'd

 Invalid write of size 1
    at 0x4A0940E: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)
  Address 0x4c7192d is not stack'd, malloc'd or (recently) free'd

 Process terminating with default action of signal 11 (SIGSEGV)
  Access not within mapped region at address 0x502F000
    at 0x4A09400: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)

This happens when tail - head == -1 here:
(parsing.c)

  char *substr(const char *head, const char *tail)
  {
          char *buf;

          buf = xmalloc(tail - head + 1);
          strncpy(buf, head, tail - head);
          buf[tail - head] = '\0';
          return buf;
  }

  char *parse_user(char *t, char **name, char **email, unsigned long *date)
  {
          char *p = t;
          int mode = 1;

          while (p &amp;&amp; *p) {
                  if (mode == 1 &amp;&amp; *p == '&lt;') {
                          *name = substr(t, p - 1);
                          t = p;
                          mode++;
                  } else if (mode == 1 &amp;&amp; *p == '\n') {

The fix is to handle the case of (tail &lt; head) before calling xmalloc,
thus avoiding passing an invalid value to xmalloc.

And here's the reproducer:
It was tricky to reproduce, because git prohibits use of an empty "name"
in a commit ID.  To construct the offending commit, I had to resort to
using "git hash-object".

git init -q foo &amp;&amp;
( cd foo &amp;&amp;
  echo a &gt; j &amp;&amp; git add . &amp;&amp; git ci -q --author='au &lt;T at h.or&gt;' -m. . &amp;&amp;
  h=$(git cat-file commit HEAD|sed 's/au //' \
    |git hash-object -t commit -w --stdin) &amp;&amp;
  git co -q -b test $h &amp;&amp;
  git br -q -D master &amp;&amp;
  git br -q -m test master)
git clone -q --bare foo foo.git

cat &lt;&lt;EOF &gt; in
repo.url=foo.git
repo.path=foo.git
EOF
CGIT_CONFIG=in QUERY_STRING=url=foo.git valgrind ./cgit

The valgrind output is what you see above.

AFAICS, this is not exploitable thanks (ironically) to the use of strncpy.
Since that -1 translates to SIZE_MAX and this is strncpy, not only does it
copy whatever is in "head" (up to first NUL), but it also writes
SIZE_MAX - strlen(head) NUL bytes into the destination buffer, and that
latter is guaranteed to evoke a segfault.  Since cgit is single-threaded,
AFAICS, there is no way that the buffer clobbering can be turned into
an exploit.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* parsing.c (substr): Handle tail &lt; head.

This started when I noticed some cgit segfaults on savannah.gnu.org.
Finding the offending URL/commit and then constructing a stand-alone
reproducer were far more time-consuming than writing the actual patch.

The problem arises with a commit like this, in which the user name
part of the "Author" field is empty:

    $ git log -1
    commit 6f3f41d73393278f3ede68a2cb1e7a2a23fa3421
    Author: &lt;T at h.or&gt;
    Date:   Mon Apr 23 22:29:16 2012 +0200

Here's what happens:

(this is due to buf=malloc(0); strncpy (buf, head, -1);
 where "head" may point to plenty of attacker-specified non-NUL bytes,
 so we can overwrite a zero-length heap buffer with arbitrary data)

 Invalid write of size 1
    at 0x4A09361: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)
  Address 0x4c718d0 is 0 bytes after a block of size 0 alloc'd
    at 0x4A0884D: malloc (vg_replace_malloc.c:263)
    by 0x455C85: xmalloc (wrapper.c:35)
    by 0x40894C: substr (parsing.c:60)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)

 Invalid write of size 1
    at 0x4A09400: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)
  Address 0x4c7192b is not stack'd, malloc'd or (recently) free'd

 Invalid write of size 1
    at 0x4A0940E: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)
  Address 0x4c7192d is not stack'd, malloc'd or (recently) free'd

 Process terminating with default action of signal 11 (SIGSEGV)
  Access not within mapped region at address 0x502F000
    at 0x4A09400: strncpy (mc_replace_strmem.c:463)
    by 0x408977: substr (parsing.c:61)
    by 0x4089EF: parse_user (parsing.c:73)
    by 0x408D10: cgit_parse_commit (parsing.c:153)
    by 0x40A540: cgit_mk_refinfo (shared.c:171)
    by 0x40A581: cgit_refs_cb (shared.c:181)
    by 0x43DEB3: do_for_each_ref (refs.c:690)
    by 0x41075E: cgit_print_branches (ui-refs.c:191)
    by 0x416EF2: cgit_print_summary (ui-summary.c:56)
    by 0x40780A: summary_fn (cmd.c:120)
    by 0x40667A: process_request (cgit.c:544)
    by 0x404078: cache_process (cache.c:322)

This happens when tail - head == -1 here:
(parsing.c)

  char *substr(const char *head, const char *tail)
  {
          char *buf;

          buf = xmalloc(tail - head + 1);
          strncpy(buf, head, tail - head);
          buf[tail - head] = '\0';
          return buf;
  }

  char *parse_user(char *t, char **name, char **email, unsigned long *date)
  {
          char *p = t;
          int mode = 1;

          while (p &amp;&amp; *p) {
                  if (mode == 1 &amp;&amp; *p == '&lt;') {
                          *name = substr(t, p - 1);
                          t = p;
                          mode++;
                  } else if (mode == 1 &amp;&amp; *p == '\n') {

The fix is to handle the case of (tail &lt; head) before calling xmalloc,
thus avoiding passing an invalid value to xmalloc.

And here's the reproducer:
It was tricky to reproduce, because git prohibits use of an empty "name"
in a commit ID.  To construct the offending commit, I had to resort to
using "git hash-object".

git init -q foo &amp;&amp;
( cd foo &amp;&amp;
  echo a &gt; j &amp;&amp; git add . &amp;&amp; git ci -q --author='au &lt;T at h.or&gt;' -m. . &amp;&amp;
  h=$(git cat-file commit HEAD|sed 's/au //' \
    |git hash-object -t commit -w --stdin) &amp;&amp;
  git co -q -b test $h &amp;&amp;
  git br -q -D master &amp;&amp;
  git br -q -m test master)
git clone -q --bare foo foo.git

cat &lt;&lt;EOF &gt; in
repo.url=foo.git
repo.path=foo.git
EOF
CGIT_CONFIG=in QUERY_STRING=url=foo.git valgrind ./cgit

The valgrind output is what you see above.

AFAICS, this is not exploitable thanks (ironically) to the use of strncpy.
Since that -1 translates to SIZE_MAX and this is strncpy, not only does it
copy whatever is in "head" (up to first NUL), but it also writes
SIZE_MAX - strlen(head) NUL bytes into the destination buffer, and that
latter is guaranteed to evoke a segfault.  Since cgit is single-threaded,
AFAICS, there is no way that the buffer clobbering can be turned into
an exploit.
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-snapshot: pass -n to gzip, to suppress timestamp</title>
<updated>2012-09-27T01:35:25+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-09-26T00:56:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=055e092a330098f6b9177266facf43029dbe1883'/>
<id>055e092a330098f6b9177266facf43029dbe1883</id>
<content type='text'>
Since cgit snapshots of tags are often used for releases, we don't
want the rarely used feature of the gzip compressor that includes
an embedded timestamp into the archive, since this makes each tarball
of the same (potentially signed) tag different.

This commit refactors the archive handling code a bit so that each
different format is able to run with an arbitrary argv for the filter.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since cgit snapshots of tags are often used for releases, we don't
want the rarely used feature of the gzip compressor that includes
an embedded timestamp into the archive, since this makes each tarball
of the same (potentially signed) tag different.

This commit refactors the archive handling code a bit so that each
different format is able to run with an arbitrary argv for the filter.
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright headers to have latest dates.</title>
<updated>2012-07-12T18:01:46+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-07-12T18:00:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=7f08e03941c40a56fb1b5b3df62aa819fb2d6554'/>
<id>7f08e03941c40a56fb1b5b3df62aa819fb2d6554</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-repolist: Case insensitive sorting and age sort</title>
<updated>2012-07-12T18:01:46+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-07-12T17:13:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=184c5655b2e350dbd0dd8be75d3f370f22aa6dee'/>
<id>184c5655b2e350dbd0dd8be75d3f370f22aa6dee</id>
<content type='text'>
Add two options, one for doing the ordinary name sorts in a
case-insensitive manner, and another for choosing to sort repos in each
section by age instead of by name.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add two options, one for doing the ordinary name sorts in a
case-insensitive manner, and another for choosing to sort repos in each
section by age instead of by name.
</pre>
</div>
</content>
</entry>
<entry>
<title>scan-tree: Support gitweb.category.</title>
<updated>2012-07-12T18:01:46+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-07-11T03:32:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=fc9181ff3d3ebbe0159871f6a49438e60bb17f58'/>
<id>fc9181ff3d3ebbe0159871f6a49438e60bb17f58</id>
<content type='text'>
Use gitweb.category from git config to determine repo's section, if
option is enabled.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use gitweb.category from git config to determine repo's section, if
option is enabled.
</pre>
</div>
</content>
</entry>
<entry>
<title>scan-tree: Support gitweb.description.</title>
<updated>2012-07-12T18:01:46+00:00</updated>
<author>
<name>Jason A. Donenfeld</name>
<email>Jason@zx2c4.com</email>
</author>
<published>2012-07-11T02:24:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=b56be4ba3a942dd1978fe4bfecd9afc35aab0027'/>
<id>b56be4ba3a942dd1978fe4bfecd9afc35aab0027</id>
<content type='text'>
Use gitweb.description instead of description file to determine
description, if option is enabled.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use gitweb.description instead of description file to determine
description, if option is enabled.
</pre>
</div>
</content>
</entry>
<entry>
<title>css: only use div#cgit</title>
<updated>2012-03-20T07:00:20+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-19T22:09:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=45555512ba63b823c6340875254563ea05737668'/>
<id>45555512ba63b823c6340875254563ea05737668</id>
<content type='text'>
Don't bother with 'body' and 'div#cgit form', since
everything is wrapped in 'div#cgit' already.
Removing these two types makes embedding even easier.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't bother with 'body' and 'div#cgit form', since
everything is wrapped in 'div#cgit' already.
Removing these two types makes embedding even easier.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fh/mimetypes'</title>
<updated>2012-03-18T21:01:28+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T21:01:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=ae90a0b2d18d66e7b1cb98b2e34fd697f8b5311a'/>
<id>ae90a0b2d18d66e7b1cb98b2e34fd697f8b5311a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'jp/defbranch'</title>
<updated>2012-03-18T21:00:18+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T21:00:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=181b6e789b79fc385e5ec75b2b83f01192d54051'/>
<id>181b6e789b79fc385e5ec75b2b83f01192d54051</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'lh/module-links'</title>
<updated>2012-03-18T20:59:36+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T20:59:36+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=2b9fab8d30420d935745c4d84ea22412ab2485e5'/>
<id>2b9fab8d30420d935745c4d84ea22412ab2485e5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2012-03-18T20:23:30+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T20:23:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=08352c7a02f057f6cbaf817ca7e53c53be590a62'/>
<id>08352c7a02f057f6cbaf817ca7e53c53be590a62</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>css: force text color to black on decorations</title>
<updated>2012-03-18T20:22:51+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T10:44:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=6e63ebfe004342cbe35e0b0f28de646ffa61933a'/>
<id>6e63ebfe004342cbe35e0b0f28de646ffa61933a</id>
<content type='text'>
improves readability when embedding into a page that
has the text color set to a different color

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
improves readability when embedding into a page that
has the text color set to a different color

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>css: vertically align the cgit logo image</title>
<updated>2012-03-18T20:22:18+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T10:44:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=fac65a7ed2d10f83d0df27e66e1c67e11663c220'/>
<id>fac65a7ed2d10f83d0df27e66e1c67e11663c220</id>
<content type='text'>
When embedding cgit in other pages, the logo alignment needs to be
specified to avoid any css rules from the embedding page to make the
page look bad.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When embedding cgit in other pages, the logo alignment needs to be
specified to avoid any css rules from the embedding page to make the
page look bad.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>css: prefix all styles with div#cgit</title>
<updated>2012-03-18T20:22:02+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T10:44:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=add1ccb1d805e9472483e49c3ce55a2e30bf5aae'/>
<id>add1ccb1d805e9472483e49c3ce55a2e30bf5aae</id>
<content type='text'>
to facilitate easier embedding

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
to facilitate easier embedding

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>filters/syntax-highlighting.sh: work around highlight --force bug</title>
<updated>2012-03-18T20:12:36+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T11:48:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=f50be7fda0a7ab57009169dd5905fcbab8eb5166'/>
<id>f50be7fda0a7ab57009169dd5905fcbab8eb5166</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>filters/highlight.sh: manually support highlight version 2 and 3</title>
<updated>2012-03-18T20:12:35+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T11:38:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=375353caffb0a251e7f0174aa9b73cc1961e93fd'/>
<id>375353caffb0a251e7f0174aa9b73cc1961e93fd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: properly quote arguments to printf</title>
<updated>2012-03-18T10:54:50+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T10:43:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=561959cffa3de67986d193469b77c8db0d307400'/>
<id>561959cffa3de67986d193469b77c8db0d307400</id>
<content type='text'>
v2: incorporate remarks of Lukas

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
v2: incorporate remarks of Lukas

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: handle paths with whitespace</title>
<updated>2012-03-18T10:54:42+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2012-03-18T10:43:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=f8492f79a3b1193ae1a412eb7c4f3b0c2b21ecaa'/>
<id>f8492f79a3b1193ae1a412eb7c4f3b0c2b21ecaa</id>
<content type='text'>
v2: incorporate remarks of Lukas

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
v2: incorporate remarks of Lukas

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2012-03-18T10:19:59+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T10:19:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=7996157f14d99ee6d26c042816e12bd9089c1efb'/>
<id>7996157f14d99ee6d26c042816e12bd9089c1efb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CGIT-0.9.0.3</title>
<updated>2012-03-18T10:16:27+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T10:16:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=e032761a5ebc3372ab0abd0c9bcd8436d89485ae'/>
<id>e032761a5ebc3372ab0abd0c9bcd8436d89485ae</id>
<content type='text'>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2012-03-18T10:10:10+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-03-18T10:10:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=961893b5478e7676b1a422185fcac41f89434b0a'/>
<id>961893b5478e7676b1a422185fcac41f89434b0a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>segfault fix on some bogus requests</title>
<updated>2012-03-18T09:26:31+00:00</updated>
<author>
<name>Eric Wong</name>
<email>normalperson@yhbt.net</email>
</author>
<published>2012-01-04T09:01:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=21418ec42a9a2de4c2c22eca7a1183b311914eca'/>
<id>21418ec42a9a2de4c2c22eca7a1183b311914eca</id>
<content type='text'>
ctx.qry.head can be NULL in some cases due to bad requests
by weird bots.  I managed to reproduce with:

   PATH_INFO=/repo.git/shop.php QUERY_STRING=id=

Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ctx.qry.head can be NULL in some cases due to bad requests
by weird bots.  I managed to reproduce with:

   PATH_INFO=/repo.git/shop.php QUERY_STRING=id=

Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>use correct type for sizeof</title>
<updated>2012-03-18T09:26:31+00:00</updated>
<author>
<name>Jamie Couture</name>
<email>jamie.couture@gmail.com</email>
</author>
<published>2012-01-12T03:38:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=6a575b8900734a4640427416885e73c83af70736'/>
<id>6a575b8900734a4640427416885e73c83af70736</id>
<content type='text'>
**L would have worked well too.  Depending on the distribution sizeof *L
may return 8 instead of 4. **L is preferable, but since we don't expect
this datatype to change very often, sizeof int is less subtle and easier
to understand.

Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**L would have worked well too.  Depending on the distribution sizeof *L
may return 8 instead of 4. **L is preferable, but since we don't expect
this datatype to change very often, sizeof int is less subtle and easier
to understand.

Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-ssdiff.c: correct length check for LCS table</title>
<updated>2012-01-08T10:01:49+00:00</updated>
<author>
<name>Eric Wong</name>
<email>normalperson@yhbt.net</email>
</author>
<published>2012-01-04T08:59:15+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=19c31231fac828bb336db67b8cccc871bea1500e'/>
<id>19c31231fac828bb336db67b8cccc871bea1500e</id>
<content type='text'>
Each individual string may be too long for its respective
dimension of the LCS table.

Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Each individual string may be too long for its respective
dimension of the LCS table.

Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2012-01-03T21:19:29+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-01-03T21:19:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=1de3048d08fc6491630c45437f88f5ab03c0508f'/>
<id>1de3048d08fc6491630c45437f88f5ab03c0508f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix segmentation fault in empty repository</title>
<updated>2012-01-03T21:00:30+00:00</updated>
<author>
<name>John Keeping</name>
<email>john@metanate.com</email>
</author>
<published>2011-11-24T11:54:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=94b7c76e531315b245f79a9e2dfd0655e6e45fee'/>
<id>94b7c76e531315b245f79a9e2dfd0655e6e45fee</id>
<content type='text'>
When a repository is empty, the ATOM feed link is written in the header,
but this involves formatting ctx-&gt;qry.head which is NULL in this case.
With glibc, vsnprintf formats "%s" with a NULL input as "(null)" but on
Solaris this results in a segmentation fault.  Since we don't have a
meaningful head for the atom feed in an empty repository, it's simplest
not to write out the link element at all.

Signed-off-by: John Keeping &lt;john@metanate.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a repository is empty, the ATOM feed link is written in the header,
but this involves formatting ctx-&gt;qry.head which is NULL in this case.
With glibc, vsnprintf formats "%s" with a NULL input as "(null)" but on
Solaris this results in a segmentation fault.  Since we don't have a
meaningful head for the atom feed in an empty repository, it's simplest
not to write out the link element at all.

Signed-off-by: John Keeping &lt;john@metanate.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2012-01-03T16:48:22+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-01-03T16:48:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=aa25ff3c8b548077f2793c1162f3610af03e63df'/>
<id>aa25ff3c8b548077f2793c1162f3610af03e63df</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: fetch git tarballs from http://hjemli.net/git/git/</title>
<updated>2012-01-03T16:43:33+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-01-03T16:43:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=fbd254d54e28e002a0d56b81c192156599df1e6b'/>
<id>fbd254d54e28e002a0d56b81c192156599df1e6b</id>
<content type='text'>
The git tarballs are currently not available from kernel.org, so for now
the makefile will download autogenerated tarballs from cgit.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The git tarballs are currently not available from kernel.org, so for now
the makefile will download autogenerated tarballs from cgit.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fix css color value and vertical-align value</title>
<updated>2012-01-03T16:25:46+00:00</updated>
<author>
<name>Norberto Lopes</name>
<email>nlopes.ml@gmail.com</email>
</author>
<published>2011-11-23T01:59:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=dad620ee56b9c7e1a3217eba7ee750c4aa8d7e71'/>
<id>dad620ee56b9c7e1a3217eba7ee750c4aa8d7e71</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-ssdiff.c: set correct diffmode in "control panel"</title>
<updated>2012-01-03T16:09:59+00:00</updated>
<author>
<name>Tim Chen</name>
<email>timchen1@gmail.com</email>
</author>
<published>2012-01-03T16:09:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=195742572681d6c2583de392131d1be86ef52f48'/>
<id>195742572681d6c2583de392131d1be86ef52f48</id>
<content type='text'>
When side-by-side-diffs=1 was set in cgitrc, specifying 'ss=0' in the
querystring would not set the 'unified' option as active in the dropdown
box used to select diffmode.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When side-by-side-diffs=1 was set in cgitrc, specifying 'ss=0' in the
querystring would not set the 'unified' option as active in the dropdown
box used to select diffmode.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2012-01-03T16:06:58+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2012-01-03T16:06:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=04254fa903701943bd45a479a952cc213a5b112a'/>
<id>04254fa903701943bd45a479a952cc213a5b112a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix diff mode switching when side-by-side-diffs=1</title>
<updated>2012-01-03T16:02:14+00:00</updated>
<author>
<name>Tim Chen</name>
<email>timchen1@gmail.com</email>
</author>
<published>2012-01-03T16:02:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=f2ced535e9f2c2ada7f184735a07a1190a9d810f'/>
<id>f2ced535e9f2c2ada7f184735a07a1190a9d810f</id>
<content type='text'>
When side-by-side-diffs=1 was set in cgitrc, specyfing 'ss=0' in the query-
string would not switch to unified diffs. This patch fixes the issue by
introducing a separate variable to track the occurrence of "ss" in the
querystring.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When side-by-side-diffs=1 was set in cgitrc, specyfing 'ss=0' in the query-
string would not switch to unified diffs. This patch fixes the issue by
introducing a separate variable to track the occurrence of "ss" in the
querystring.
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-log.c: do not show remote heads if enable-remote-branches=0</title>
<updated>2012-01-03T15:35:06+00:00</updated>
<author>
<name>Georg Müller</name>
<email>georgmueller@gmx.net</email>
</author>
<published>2012-01-03T15:30:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=0b6a716d1b9f18e8cc00940a7962e542b9358238'/>
<id>0b6a716d1b9f18e8cc00940a7962e542b9358238</id>
<content type='text'>
If remote branches are not enabled, the branches are still listed in
the log view. This patch removes them if enable-remote-branches=0.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If remote branches are not enabled, the branches are still listed in
the log view. This patch removes them if enable-remote-branches=0.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add sort parameter to pager of repo list</title>
<updated>2012-01-03T15:20:17+00:00</updated>
<author>
<name>Tobias Grimm</name>
<email>git@e-tobi.net</email>
</author>
<published>2011-07-31T00:44:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=7530d94f05887b8065742adb614c368d8568a22c'/>
<id>7530d94f05887b8065742adb614c368d8568a22c</id>
<content type='text'>
When the repolist is paged, the page-links are missing the sort parameter,
causing the initial page to be custom sorted, but any clicked page will
then be with the default sort order again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When the repolist is paged, the page-links are missing the sort parameter,
causing the initial page to be custom sorted, but any clicked page will
then be with the default sort order again.
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-ssdiff: move LCS table away from the stack</title>
<updated>2012-01-03T15:16:01+00:00</updated>
<author>
<name>Jamie Couture</name>
<email>jamie.couture@gmail.com</email>
</author>
<published>2011-09-17T22:25:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=e19f7d7180d64c8ba9ca15f5fe164606f0ec88c1'/>
<id>e19f7d7180d64c8ba9ca15f5fe164606f0ec88c1</id>
<content type='text'>
Printing deferred line changes for files containing long lines would
cause a segfault.

- limit LCS table size: 128x128.
- move LCS table to global context: avoid allocating/freeing memory
  for every deferred line change.

Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Printing deferred line changes for files containing long lines would
cause a segfault.

- limit LCS table size: 128x128.
- move LCS table to global context: avoid allocating/freeing memory
  for every deferred line change.

Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>shared.c: Only setenv() if value is non-null</title>
<updated>2012-01-03T14:59:36+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-09-14T09:52:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=d96d2c98ebc4c2d3765f5b35c4142e0e828a421b'/>
<id>d96d2c98ebc4c2d3765f5b35c4142e0e828a421b</id>
<content type='text'>
Some setenv() implementations (e.g. the one in OpenBSD's stdlib)
segfault if we pass a NULL value. Only set environment variables if the
corresponding settings are defined to avoid this.

Note that this is a minor behaviour change as environment variables were
supposed to be set to an empty string if a setting was undefined. Given
that this feature isn't part of any official release yet, there's no
need to worry about backwards compatibility, really. Change the
documentation accordingly.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some setenv() implementations (e.g. the one in OpenBSD's stdlib)
segfault if we pass a NULL value. Only set environment variables if the
corresponding settings are defined to avoid this.

Note that this is a minor behaviour change as environment variables were
supposed to be set to an empty string if a setting was undefined. Given
that this feature isn't part of any official release yet, there's no
need to worry about backwards compatibility, really. Change the
documentation accordingly.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>shared.c: Remove unused "linux/limits.h" include</title>
<updated>2012-01-03T14:53:41+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-07-22T15:15:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=8185169e5e2a8b9438c7a6f3f9c5eb6db5a37fea'/>
<id>8185169e5e2a8b9438c7a6f3f9c5eb6db5a37fea</id>
<content type='text'>
This isn't used anywhere and prevents the code from being compiled on
other platforms, such as *BSD.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This isn't used anywhere and prevents the code from being compiled on
other platforms, such as *BSD.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-07-22T12:22:17+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-07-22T12:22:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=756e3ea6392e30bcd0a41346d4ffa42c56d715e2'/>
<id>756e3ea6392e30bcd0a41346d4ffa42c56d715e2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix potential XSS vulnerability in rename hint</title>
<updated>2011-07-22T12:21:28+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-07-22T11:47:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=bebe89d7c11a92bf206bf6e528c51ffa8ecbc0d5'/>
<id>bebe89d7c11a92bf206bf6e528c51ffa8ecbc0d5</id>
<content type='text'>
The file name displayed in the rename hint should be escaped to avoid
XSS. Note that this vulnerability is only applicable when an attacker
has gained push access to the repository.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The file name displayed in the rename hint should be escaped to avoid
XSS. Note that this vulnerability is only applicable when an attacker
has gained push access to the repository.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove dead initialization in cgit_parse_commit()</title>
<updated>2011-07-22T12:21:11+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-07-21T21:04:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=1e25ac5b8fe0ca8760b2786b20d36013a6197e02'/>
<id>1e25ac5b8fe0ca8760b2786b20d36013a6197e02</id>
<content type='text'>
The value stored to "t" during its initialization gets overwritten in
any case, so just leave it uninitialized. Spotted by clang-analyzer.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The value stored to "t" during its initialization gets overwritten in
any case, so just leave it uninitialized. Spotted by clang-analyzer.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-07-21T14:27:03+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-07-21T14:27:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=bf8c7a4c93bdc95d841b25a60644cca3ec124625'/>
<id>bf8c7a4c93bdc95d841b25a60644cca3ec124625</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CGIT 0.9.0.2</title>
<updated>2011-07-21T14:24:10+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-07-21T14:23:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=654ebb55d4e436ad145061ffb87111cbfcd88565'/>
<id>654ebb55d4e436ad145061ffb87111cbfcd88565</id>
<content type='text'>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>html.c: avoid out-of-bounds access for url_escape_table</title>
<updated>2011-07-21T14:21:52+00:00</updated>
<author>
<name>Eric Wong</name>
<email>normalperson@yhbt.net</email>
</author>
<published>2011-07-21T03:24:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=9cae75d040d9102d4b628ba3c828d95d0251f5c0'/>
<id>9cae75d040d9102d4b628ba3c828d95d0251f5c0</id>
<content type='text'>
This fixes a segfault for me with with -O2 optimization on x86
with gcc (Debian 4.4.5-8) 4.4.5

I can reliably reproduce it with the following parameters
when pointed to the git.git repository:

PATH_INFO='/git-core.git/diff/'
QUERY_STRING='id=2b93bfac0f5bcabbf60f174f4e7bfa9e318e64d5&amp;id2=d6da71a9d16b8cf27f9d8f90692d3625c849cbc8'

Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes a segfault for me with with -O2 optimization on x86
with gcc (Debian 4.4.5-8) 4.4.5

I can reliably reproduce it with the following parameters
when pointed to the git.git repository:

PATH_INFO='/git-core.git/diff/'
QUERY_STRING='id=2b93bfac0f5bcabbf60f174f4e7bfa9e318e64d5&amp;id2=d6da71a9d16b8cf27f9d8f90692d3625c849cbc8'

Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-07-21T12:50:07+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-07-21T12:50:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=73e13e2bf7b7e794e6df9ac170452a8991137d08'/>
<id>73e13e2bf7b7e794e6df9ac170452a8991137d08</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: fix failures when CDPATH is set</title>
<updated>2011-07-21T12:48:37+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2011-07-21T12:43:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=877ff681007f31c69777e9569c4de819d4af19c9'/>
<id>877ff681007f31c69777e9569c4de819d4af19c9</id>
<content type='text'>
Some tests would otherwise fail because commands such as
  cd trash/repos/foo &amp;&amp; git rev-list --reverse HEAD | head -1
would return 2 lines instead of 1: the 'cd' command also
prints the path when CDPATH is set.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some tests would otherwise fail because commands such as
  cd trash/repos/foo &amp;&amp; git rev-list --reverse HEAD | head -1
would return 2 lines instead of 1: the 'cd' command also
prints the path when CDPATH is set.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-repolist.c: fallback to "master" if no default branch is specified</title>
<updated>2011-07-19T09:34:18+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-07-19T09:34:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=5293c8b7992bf3211b6bde7acbbd4e74ffd926d4'/>
<id>5293c8b7992bf3211b6bde7acbbd4e74ffd926d4</id>
<content type='text'>
When looking for the modtime of a repo we used to rely on repo.defbranch
having a value. This is no longer true so this patch provides a default
value when needed.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When looking for the modtime of a repo we used to rely on repo.defbranch
having a value. This is no longer true so this patch provides a default
value when needed.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui_plain: automatically lookup mimetype when mimetype-file is set</title>
<updated>2011-07-19T09:30:07+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2011-07-19T08:51:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=d01c600c179593a53162a9d4e3040ecfc5078fdc'/>
<id>d01c600c179593a53162a9d4e3040ecfc5078fdc</id>
<content type='text'>
For sites that do not want to configure mime types by hand but
still want the correct mime type for 'plain' blobs, configuring
a mime type file is made possible. This is handy since such a
file is normally already provided (at least on Linux systems).

Also, this reflects the gitweb option '$mimetypes_file'

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For sites that do not want to configure mime types by hand but
still want the correct mime type for 'plain' blobs, configuring
a mime type file is made possible. This is handy since such a
file is normally already provided (at least on Linux systems).

Also, this reflects the gitweb option '$mimetypes_file'

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: fix oversight of not using $(DESTDIR) in uninstall</title>
<updated>2011-07-19T07:15:26+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2011-07-18T10:45:56+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=96f05018c9dbdf8131f18c87ee3bbbac40e0f729'/>
<id>96f05018c9dbdf8131f18c87ee3bbbac40e0f729</id>
<content type='text'>
Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>commit-links.sh: improve regular expressions</title>
<updated>2011-07-19T07:12:02+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2011-07-18T10:45:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=afdff8dc1327ed14c94cf447272191bd28009ed1'/>
<id>afdff8dc1327ed14c94cf447272191bd28009ed1</id>
<content type='text'>
The default length for sha1 abbreviations in git is 7.

A '#num' at the beginning of the commit message is now
recognised, a ':#num' as well, etc.: a '#num' anywhere
is now converted to a link.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The default length for sha1 abbreviations in git is 7.

A '#num' at the beginning of the commit message is now
recognised, a ':#num' as well, etc.: a '#num' anywhere
is now converted to a link.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cgit.c: use resolve_ref() to guess_defbranch()</title>
<updated>2011-06-20T23:23:57+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-20T22:52:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=8d7c2ec295423fe31d9113038f6717d7b64dbe57'/>
<id>8d7c2ec295423fe31d9113038f6717d7b64dbe57</id>
<content type='text'>
The resolve_ref() function handles reading of git- and filesystem
symbolic links (including proper whitespace trimming) and packed refs.
There's no point in reimplementing this function in cgit.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The resolve_ref() function handles reading of git- and filesystem
symbolic links (including proper whitespace trimming) and packed refs.
There's no point in reimplementing this function in cgit.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Only guess default branch when a repo page is requested</title>
<updated>2011-06-20T18:59:10+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-20T18:59:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=e95c70d4ea997d1217d5c81cb3b640f3fa025df1'/>
<id>e95c70d4ea997d1217d5c81cb3b640f3fa025df1</id>
<content type='text'>
There's no need to invoke guess_defbranch() for each repo during
scan-path, since repo.defbranch is only used when repo content is
being displayed.

Also, some users prefer to register their projects manually in cgitrc
but they got no benefit from the new repo.defbranch handling.

This patch tries to rectify these issues by only invoking guess_defbranch()
when needed, regardless of how the repo was registered.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There's no need to invoke guess_defbranch() for each repo during
scan-path, since repo.defbranch is only used when repo content is
being displayed.

Also, some users prefer to register their projects manually in cgitrc
but they got no benefit from the new repo.defbranch handling.

This patch tries to rectify these issues by only invoking guess_defbranch()
when needed, regardless of how the repo was registered.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>guess default branch from HEAD</title>
<updated>2011-06-20T18:42:19+00:00</updated>
<author>
<name>Julius Plenz</name>
<email>plenz@cis.fu-berlin.de</email>
</author>
<published>2011-04-07T10:59:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=d711de55280c3c9c10cfda4e24c8f3b3015217b2'/>
<id>d711de55280c3c9c10cfda4e24c8f3b3015217b2</id>
<content type='text'>
This is a saner alternative than hardcoding the default branch to be
"master". The add_repo() function will now check for a symbolic ref in
repo_path/HEAD. If there is a suitable one, overwrite repo-&gt;defbranch
with it. Note that you'll need to strip the newline from the file (-&gt;
len-17).

If HEAD is a symbolic link pointing directly to a branch below
refs/heads/, do a readlink() instead to find the ref name.

Signed-off-by: Julius Plenz &lt;plenz@cis.fu-berlin.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a saner alternative than hardcoding the default branch to be
"master". The add_repo() function will now check for a symbolic ref in
repo_path/HEAD. If there is a suitable one, overwrite repo-&gt;defbranch
with it. Note that you'll need to strip the newline from the file (-&gt;
len-17).

If HEAD is a symbolic link pointing directly to a branch below
refs/heads/, do a readlink() instead to find the ref name.

Signed-off-by: Julius Plenz &lt;plenz@cis.fu-berlin.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-18T12:59:51+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-18T12:59:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=b0d72da02850abaf4be65ff220774a457c214651'/>
<id>b0d72da02850abaf4be65ff220774a457c214651</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>cgit.c: improve error message when git repo cannot be accessed</title>
<updated>2011-06-18T12:59:01+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-18T12:32:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=9900ac022edfcfacee317d19a0f1d4d03b837b43'/>
<id>9900ac022edfcfacee317d19a0f1d4d03b837b43</id>
<content type='text'>
The current 'Not a git repository' error message is not very helpful,
since it doesn't state the cause of the problem.

This patch uses errno to provide a hint of the underlying problem. It
would have been even better to give the exact cause (e.g. for ENOENT it
would be nice to know which file/directory is missing), but that would
require reimplementing setup_git_directory_gently() which seems a bit
overkill.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current 'Not a git repository' error message is not very helpful,
since it doesn't state the cause of the problem.

This patch uses errno to provide a hint of the underlying problem. It
would have been even better to give the exact cause (e.g. for ENOENT it
would be nice to know which file/directory is missing), but that would
require reimplementing setup_git_directory_gently() which seems a bit
overkill.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Do not provide a default value for `module-link`</title>
<updated>2011-06-15T08:40:13+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-15T08:13:15+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=3fbaf097153b239b092d11a178ace96671f9f3ec'/>
<id>3fbaf097153b239b092d11a178ace96671f9f3ec</id>
<content type='text'>
The old default value was an abomination which never should have been
allowed to see the light of day.

This patch removes the default, which is a backwards incompatible change
with low probability of causing anyone any real trouble (a repo with
submodules, displayed by cgit using the default value of `module-link`,
is very unlikely to actually generate working links).

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The old default value was an abomination which never should have been
allowed to see the light of day.

This patch removes the default, which is a backwards incompatible change
with low probability of causing anyone any real trouble (a repo with
submodules, displayed by cgit using the default value of `module-link`,
is very unlikely to actually generate working links).

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-plain.c: add support for path-selected submodule links</title>
<updated>2011-06-15T08:40:13+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-15T08:10:41+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=7421857b4da9b8523032f08824bca9f3e3ebec4e'/>
<id>7421857b4da9b8523032f08824bca9f3e3ebec4e</id>
<content type='text'>
In ui-plain.c, the links generated for submodule entry ignored the fact
that the entry was in fact a submodule. This patch adds proper submodule
links to the plain directory listings.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In ui-plain.c, the links generated for submodule entry ignored the fact
that the entry was in fact a submodule. This patch adds proper submodule
links to the plain directory listings.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-tree.c: add support for path-selected submodule links</title>
<updated>2011-06-15T08:40:13+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-15T08:04:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=6857bec50a52340fa6b85d626f49d45dd331ed0e'/>
<id>6857bec50a52340fa6b85d626f49d45dd331ed0e</id>
<content type='text'>
The current 'repo.module-link' option is sufficient when all gitlinks
in a repository can be converted to commit links in a uniform way, but
not when different submodules/paths needs different settings.

This patch adds support for 'repo.module-link.&lt;path&gt;', which will be
used for linking to submodules at paths matching one such entry.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current 'repo.module-link' option is sufficient when all gitlinks
in a repository can be converted to commit links in a uniform way, but
not when different submodules/paths needs different settings.

This patch adds support for 'repo.module-link.&lt;path&gt;', which will be
used for linking to submodules at paths matching one such entry.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-15T08:40:00+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-15T08:40:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=8729d251a900b2e6e22cc4c93a2193fd8a2b9acf'/>
<id>8729d251a900b2e6e22cc4c93a2193fd8a2b9acf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>cgitrc.5.txt: document repo.module-link</title>
<updated>2011-06-15T08:39:43+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-15T07:58:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=46ca32e04319caf9dd65f9de47704d637547ad23'/>
<id>46ca32e04319caf9dd65f9de47704d637547ad23</id>
<content type='text'>
The global module-link option can be overridden per repo, but this has
never been documented.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The global module-link option can be overridden per repo, but this has
never been documented.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'lh/clone-url'</title>
<updated>2011-06-13T23:05:10+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T23:05:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=1b1bf635b59a349a9238a1d63a21d03d9949e185'/>
<id>1b1bf635b59a349a9238a1d63a21d03d9949e185</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>cgit.c: add 'clone-url' setting with support for macro expansion</title>
<updated>2011-06-13T23:04:30+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-06T20:49:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=a1429dbc89f9c0945e32cea9fd3424d2fe56aeab'/>
<id>a1429dbc89f9c0945e32cea9fd3424d2fe56aeab</id>
<content type='text'>
The current 'clone-prefix' setting has some known issues:
* All repos get the same 'clone-prefix' value since the setting is not
  adopted during repo registration (in cgitrc, or during scan-path traversal),
  but only when the setting is used.
* The generated clone-urls for a repo is a combination of 'clone-prefix', a
  slash and the repo url. This doesn't work well with e.g. ssh-style urls
  like 'git@example.org:repo.git', since the inserted slash will make the
  repo relative to the filesystem root.
* If 'remove-suffix' is enabled, the generated clone-urls will not work for
  cloning (except for http-urls to cgit itself) since they miss the '.git'
  suffix.

The new 'clone-url' setting is designed to avoid the mentioned issues:
* Each repo adopts the default 'clone-url' when the repo is defined. This
  allows different groups of repos to adopt different values.
* The clone-urls for a repo is generated by expanding environment variables
  in a string template without inserting arbitrary characters, hence any
  kind of clone-url can be generated.
* Macro expansion also eases the 'remove-suffix' pain since it's now
  possible to define e.g. 'clone-url=git://foo.org/$CGIT_REPO_URL.git' for
  a set of repos. A furter improvement would be to define e.g.
  $CGIT_REPO_SUFFIX to '.git' for all repos which had their url prettified,
  or to store the original $CGIT_REPO_URL in e.g. $CGIT_REPO_REAL_URL before
  suffix removal.

Reviewed-by: Ferry Huberts &lt;mailings@hupie.com&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current 'clone-prefix' setting has some known issues:
* All repos get the same 'clone-prefix' value since the setting is not
  adopted during repo registration (in cgitrc, or during scan-path traversal),
  but only when the setting is used.
* The generated clone-urls for a repo is a combination of 'clone-prefix', a
  slash and the repo url. This doesn't work well with e.g. ssh-style urls
  like 'git@example.org:repo.git', since the inserted slash will make the
  repo relative to the filesystem root.
* If 'remove-suffix' is enabled, the generated clone-urls will not work for
  cloning (except for http-urls to cgit itself) since they miss the '.git'
  suffix.

The new 'clone-url' setting is designed to avoid the mentioned issues:
* Each repo adopts the default 'clone-url' when the repo is defined. This
  allows different groups of repos to adopt different values.
* The clone-urls for a repo is generated by expanding environment variables
  in a string template without inserting arbitrary characters, hence any
  kind of clone-url can be generated.
* Macro expansion also eases the 'remove-suffix' pain since it's now
  possible to define e.g. 'clone-url=git://foo.org/$CGIT_REPO_URL.git' for
  a set of repos. A furter improvement would be to define e.g.
  $CGIT_REPO_SUFFIX to '.git' for all repos which had their url prettified,
  or to store the original $CGIT_REPO_URL in e.g. $CGIT_REPO_REAL_URL before
  suffix removal.

Reviewed-by: Ferry Huberts &lt;mailings@hupie.com&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cgit.c: always setup cgit repo environment variables</title>
<updated>2011-06-13T23:03:46+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-06T19:29:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=3ec6b309505dc5f7ba14abe8861b02da34a9df0b'/>
<id>3ec6b309505dc5f7ba14abe8861b02da34a9df0b</id>
<content type='text'>
When cgit learned to setup environment variables for certain repo
settings before invoking a filter process, the setup occurred inside
cgit_open_filter().

This patch moves the setup out of cgit_open_filter() and into
prepare_repo_cmd() to prepare for additional uses of these variables.

Reviewed-by: Ferry Huberts &lt;mailings@hupie.com&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When cgit learned to setup environment variables for certain repo
settings before invoking a filter process, the setup occurred inside
cgit_open_filter().

This patch moves the setup out of cgit_open_filter() and into
prepare_repo_cmd() to prepare for additional uses of these variables.

Reviewed-by: Ferry Huberts &lt;mailings@hupie.com&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cgitrc.5.txt: reformat the "FILTER API" section</title>
<updated>2011-06-13T22:34:13+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T22:34:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=b88cda6e5b4472fc1bb0ae00d9fb974ec4f61d7a'/>
<id>b88cda6e5b4472fc1bb0ae00d9fb974ec4f61d7a</id>
<content type='text'>
This patch makes the generated man-page for the filer api section more
similar to the other sections. Also, the bulleted list of environment
variables wasn't rendered correctly (with asciidoc 8.5.2), without an
empty line before the first item.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch makes the generated man-page for the filer api section more
similar to the other sections. Also, the bulleted list of environment
variables wasn't rendered correctly (with asciidoc 8.5.2), without an
empty line before the first item.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-13T22:02:02+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T22:02:02+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=859d106d5e8d884bf8f25b2ceea8600b2987c387'/>
<id>859d106d5e8d884bf8f25b2ceea8600b2987c387</id>
<content type='text'>
Conflicts:
	cgitrc.5.txt
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:
	cgitrc.5.txt
</pre>
</div>
</content>
</entry>
<entry>
<title>cgitrc.5.txt: describe macro expansion of cgitrc options</title>
<updated>2011-06-13T21:59:50+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T21:58:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=ef13e5eafe16474bb5b3c3b8156bbb24a9249b2e'/>
<id>ef13e5eafe16474bb5b3c3b8156bbb24a9249b2e</id>
<content type='text'>
This is a new feature in cgit-0.9 which was formerly undocumented.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a new feature in cgit-0.9 which was formerly undocumented.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-13T13:28:18+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T13:28:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=be6991c1e42d548848bf2f51fd9910d14b5bdf40'/>
<id>be6991c1e42d548848bf2f51fd9910d14b5bdf40</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>README: update some stale information/add some new</title>
<updated>2011-06-13T13:27:32+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T13:24:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=2a0c9dcbe81db150bd778ce1ea1aff550d198c4d'/>
<id>2a0c9dcbe81db150bd778ce1ea1aff550d198c4d</id>
<content type='text'>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-13T12:41:01+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T12:41:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=19e371c557bfb7c085ac343b901eb998de417e75'/>
<id>19e371c557bfb7c085ac343b901eb998de417e75</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CGIT 0.9.0.1</title>
<updated>2011-06-13T12:37:04+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-13T12:37:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=978275222307f6a23dba5b093189f162a7ec2351'/>
<id>978275222307f6a23dba5b093189f162a7ec2351</id>
<content type='text'>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-12T21:23:14+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-12T21:23:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=fb3b94710febc3fb456201ce3486d09f65d0946f'/>
<id>fb3b94710febc3fb456201ce3486d09f65d0946f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-plain.c: fix html and links generated by print_dir() and print_dir_entry()</title>
<updated>2011-06-12T21:21:30+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-12T20:49:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=7f88d20823ad9d375900657334bc27793860f6ee'/>
<id>7f88d20823ad9d375900657334bc27793860f6ee</id>
<content type='text'>
This patch fixes the following issues:
* the base argument usually isn't zero-terminated, so printing base
  without considering baselen will usually generate random garbage
* when the current url represents a directory but doesn't end in a slash,
  relative urls would be incorrect
* using unescaped paths allows XSS

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch fixes the following issues:
* the base argument usually isn't zero-terminated, so printing base
  without considering baselen will usually generate random garbage
* when the current url represents a directory but doesn't end in a slash,
  relative urls would be incorrect
* using unescaped paths allows XSS

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-06T19:12:21+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-06T19:12:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=f8f6e1fe789e9dbcea40a0f8d5ebfb019c2a1a19'/>
<id>f8f6e1fe789e9dbcea40a0f8d5ebfb019c2a1a19</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>scan-tree.c: avoid memory leak</title>
<updated>2011-06-06T19:10:31+00:00</updated>
<author>
<name>Jamie Couture</name>
<email>jamie.couture@gmail.com</email>
</author>
<published>2011-06-03T23:21:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=2a8f553163d642e60092ced20631e1020581273b'/>
<id>2a8f553163d642e60092ced20631e1020581273b</id>
<content type='text'>
No references are kept to the memory pointed to by the 'rel' variable, so
it should be free()'d before returning from add_repo().

Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
Signed-off-by: Lars Hjemli &lt;larsh@hjemli.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
No references are kept to the memory pointed to by the 'rel' variable, so
it should be free()'d before returning from add_repo().

Signed-off-by: Jamie Couture &lt;jamie.couture@gmail.com&gt;
Signed-off-by: Lars Hjemli &lt;larsh@hjemli.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-06-02T10:33:23+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-02T10:33:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=7eb9f9e980c2ce1d93c979c4725cf7b60083b7b4'/>
<id>7eb9f9e980c2ce1d93c979c4725cf7b60083b7b4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-log.c: do not link from age column</title>
<updated>2011-06-02T10:30:26+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-02T10:30:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=d885158f6ac29e04bd14dd132331c7e3a93e7490'/>
<id>d885158f6ac29e04bd14dd132331c7e3a93e7490</id>
<content type='text'>
The link url wasn't properly escaped, and since the link was identical
to the one used on the commit message it didn't serve any special purpose.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The link url wasn't properly escaped, and since the link was identical
to the one used on the commit message it didn't serve any special purpose.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-snapshot.c: remove debug cruft</title>
<updated>2011-06-02T10:26:41+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-06-02T10:26:41+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=2aabeaf834a47c2fd64e045a28cd2e5b90658939'/>
<id>2aabeaf834a47c2fd64e045a28cd2e5b90658939</id>
<content type='text'>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-stats.c: fix invalid html</title>
<updated>2011-05-30T22:21:22+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-30T22:21:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=9acd1cf137ae6c91bafa91f6a073b7908e7ea695'/>
<id>9acd1cf137ae6c91bafa91f6a073b7908e7ea695</id>
<content type='text'>
Found by http://validator.w3.org.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Found by http://validator.w3.org.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-05-30T21:57:25+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-30T21:57:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=52fbcf2ffac0025128cc1d50681a7ccd859ef3f0'/>
<id>52fbcf2ffac0025128cc1d50681a7ccd859ef3f0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Properly escape ampersands inside HTML attributes</title>
<updated>2011-05-30T21:55:19+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-05-24T18:38:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=69382320d96232ee8c73e664797da61e733c2427'/>
<id>69382320d96232ee8c73e664797da61e733c2427</id>
<content type='text'>
Ampersands ("&amp;") appearing inside HTML attributes need to be translated
to "&amp;amp;". Otherwise, invalid XHTML will be generated at various
places, such as at tree views containing links to submodules.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ampersands ("&amp;") appearing inside HTML attributes need to be translated
to "&amp;amp;". Otherwise, invalid XHTML will be generated at various
places, such as at tree views containing links to submodules.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui_repolist: get modtime from packed-refs as fallback</title>
<updated>2011-05-30T21:15:31+00:00</updated>
<author>
<name>Ferry Huberts</name>
<email>ferry.huberts@pelagic.nl</email>
</author>
<published>2011-05-13T21:09:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=21e0e0bfac660072a4518f91f59d5c4bf6e764b5'/>
<id>21e0e0bfac660072a4518f91f59d5c4bf6e764b5</id>
<content type='text'>
When no modtime could be determined then as a final
fallback try to get it from the packed-refs.

This will show an idle time when a repository has been packed
with all refs in the packed-refs.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When no modtime could be determined then as a final
fallback try to get it from the packed-refs.

This will show an idle time when a repository has been packed
with all refs in the packed-refs.

Signed-off-by: Ferry Huberts &lt;ferry.huberts@pelagic.nl&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'lh/panel'</title>
<updated>2011-05-23T21:29:24+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-23T21:29:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=2ffeecb7a6827dcf0f81cf543ed312155f6e8f83'/>
<id>2ffeecb7a6827dcf0f81cf543ed312155f6e8f83</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fh/filter-api'</title>
<updated>2011-05-23T21:28:38+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-23T21:28:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=ab350a77b1d3b0e251cc28329f2e16f0566e521e'/>
<id>ab350a77b1d3b0e251cc28329f2e16f0566e521e</id>
<content type='text'>
Conflicts:
	cgit.c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:
	cgit.c
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'stable'</title>
<updated>2011-05-23T21:26:10+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-23T21:26:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=652a5a18db3b0409fedfaf8c5720446d87628ba0'/>
<id>652a5a18db3b0409fedfaf8c5720446d87628ba0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix virtual-root if script-name is ""</title>
<updated>2011-05-23T21:20:59+00:00</updated>
<author>
<name>Mark Lodato</name>
<email>lodatom@gmail.com</email>
</author>
<published>2011-05-13T23:59:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=ec79265f2053e6dc20e0ec486719f5954d2be83d'/>
<id>ec79265f2053e6dc20e0ec486719f5954d2be83d</id>
<content type='text'>
In d0cb841 (Avoid trailing slash in virtual-root), virtual-root was set
from script-name using trim_end().  However, if script-name was the
empty string (""), which happens when cgit is used to serve the root
path on a domain (/), trim_end() returns NULL and cgit acts like
virtual-root is not available.  Now, set virtual-root to "" in this
case, which fixes this bug.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In d0cb841 (Avoid trailing slash in virtual-root), virtual-root was set
from script-name using trim_end().  However, if script-name was the
empty string (""), which happens when cgit is used to serve the root
path on a domain (/), trim_end() returns NULL and cgit acts like
virtual-root is not available.  Now, set virtual-root to "" in this
case, which fixes this bug.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ui-repolist.c: do not return random/stale data from read_agefile</title>
<updated>2011-05-23T21:17:10+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-23T21:10:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=c8ea73caabcb16ffb74baa70d35650027ed772c4'/>
<id>c8ea73caabcb16ffb74baa70d35650027ed772c4</id>
<content type='text'>
When git/date.c:parse_date() cannot parse its input it returns -1. But
read_agefile() checks if the result is different from zero, essentialy
returning random data from the date buffer when parsing fails. This
patch fixes the issue by verifying that the result from parse_date()
is positive.

Noticed-by: Julius Plenz &lt;plenz@cis.fu-berlin.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When git/date.c:parse_date() cannot parse its input it returns -1. But
read_agefile() checks if the result is different from zero, essentialy
returning random data from the date buffer when parsing fails. This
patch fixes the issue by verifying that the result from parse_date()
is positive.

Noticed-by: Julius Plenz &lt;plenz@cis.fu-berlin.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid null pointer dereference in cgit_print_diff().</title>
<updated>2011-05-23T20:58:35+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-04-05T08:38:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=9afc883297b0d0943e9b358d2299950f33e8e5ed'/>
<id>9afc883297b0d0943e9b358d2299950f33e8e5ed</id>
<content type='text'>
When calling cgit_print_diff() with a bad new_rev and a NULL old_rev,
checking for new_rev's parent commit will result in a null pointer
dereference. Returning on an invalid commit before dereferencing fixes
this. Spotted with clang-analyzer.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When calling cgit_print_diff() with a bad new_rev and a NULL old_rev,
checking for new_rev's parent commit will result in a null pointer
dereference. Returning on an invalid commit before dereferencing fixes
this. Spotted with clang-analyzer.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid null pointer dereference in reencode().</title>
<updated>2011-05-23T20:58:35+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-04-05T08:35:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=a0bf375a1a9b74056a913f3687c6f5b42ad4acf6'/>
<id>a0bf375a1a9b74056a913f3687c6f5b42ad4acf6</id>
<content type='text'>
Returning "*txt" if "txt" is a null pointer is a bad thing. Spotted with
clang-analyzer.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Returning "*txt" if "txt" is a null pointer is a bad thing. Spotted with
clang-analyzer.

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix memory leak in http_parse_querystring().</title>
<updated>2011-05-23T20:58:35+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-03-30T23:21:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=070e109c1413d28b54eb6123a9fd24ac98897554'/>
<id>070e109c1413d28b54eb6123a9fd24ac98897554</id>
<content type='text'>
Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused variable from cgit_diff_tree().</title>
<updated>2011-05-23T20:58:35+00:00</updated>
<author>
<name>Lukas Fleischer</name>
<email>cgit@cryptocrack.de</email>
</author>
<published>2011-03-30T17:17:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=c9059710e7a1dbd47c22c412e0ba8f591105e3cf'/>
<id>c9059710e7a1dbd47c22c412e0ba8f591105e3cf</id>
<content type='text'>
Seen with "-Wunused-but-set-variable".

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Seen with "-Wunused-but-set-variable".

Signed-off-by: Lukas Fleischer &lt;cgit@cryptocrack.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>shared.c: do not modify const memory</title>
<updated>2011-05-23T20:58:35+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-22T10:45:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=dc1a8eadd4c063fe6782fa99f9db41c46b85d048'/>
<id>dc1a8eadd4c063fe6782fa99f9db41c46b85d048</id>
<content type='text'>
Noticed-by: zhongjj &lt;zhongjj@lemote.com&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Noticed-by: zhongjj &lt;zhongjj@lemote.com&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: add tests for links with space in path and/or args</title>
<updated>2011-05-23T20:58:35+00:00</updated>
<author>
<name>Lars Hjemli</name>
<email>hjemli@gmail.com</email>
</author>
<published>2011-05-22T10:22:56+00:00</published>
<link rel='alternate' type='text/html' href='https://git.eugenetriguba.com/forks/cgit/commit/?id=084ca50972b4be120eba8d22ce585766ae315c36'/>
<id>084ca50972b4be120eba8d22ce585766ae315c36</id>
<content type='text'>
These tests tries to detect bad links in various pages. On the log page,
there currently exists links which are not properly escaped due to the
use of cgit_fileurl() when building the link. For now, this bug is simply
tagged as such.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These tests tries to detect bad links in various pages. On the log page,
there currently exists links which are not properly escaped due to the
use of cgit_fileurl() when building the link. For now, this bug is simply
tagged as such.

Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
