From fb4135e43ece716396e6723510c3e7eddb06c85a Mon Sep 17 00:00:00 2001 From: Eugene Triguba Date: Fri, 24 Jul 2020 14:28:15 -0500 Subject: Start refactor of tests --- tests/test_reply_packet_parser.py | 73 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 tests/test_reply_packet_parser.py (limited to 'tests/test_reply_packet_parser.py') diff --git a/tests/test_reply_packet_parser.py b/tests/test_reply_packet_parser.py new file mode 100644 index 0000000..ff3c67c --- /dev/null +++ b/tests/test_reply_packet_parser.py @@ -0,0 +1,73 @@ +import os + +import pytest + +from lirc import InvalidReplyPacketFormatError, LircSocketTimeoutError + + +@pytest.mark.parametrize( + "reply_packet", [b"BEGIN\nSEND_ONCE remote key\nSUCCESS\nEND\n"] +) +def test_read_reply_packet(mock_lirc_and_socket, reply_packet): + mock_lirc, mock_socket = mock_lirc_and_socket + mock_socket.recv.return_value = reply_packet + + retrieved_packet = mock_lirc._Lirc__read_reply_packet() + + mock_socket.recv.assert_called_with(256) + assert reply_packet == retrieved_packet.encode(mock_lirc._Lirc__encoding) + + +@pytest.mark.skipif( + os.environ.get("LIRC_RUN_LONG_TESTS") is None, reason="Test takes too long" +) +@pytest.mark.parametrize("reply_packet", [b"INVALID PACKET"]) +def test_read_reply_packet_socket_timeout(mock_lirc, reply_packet): + with pytest.raises(LircSocketTimeoutError): + mock_lirc._Lirc__socket.recv.return_value = reply_packet + mock_lirc._Lirc__read_reply_packet() + + +@pytest.mark.parametrize( + "reply_packet, command, success, data, exception", + [ + ( + "BEGIN\nSEND_ONCE remote key\nSUCCESS\nEND\n", + "SEND_ONCE remote key", + True, + [], + None, + ), + ("INVALID PACKET", "", False, [], None), + ( + "BEGIN\nSEND_ONCE remote key\nERROR\nINVALID\n", + "SEND_ONCE remote key", + False, + [], + InvalidReplyPacketFormatError, + ), + ( + "BEGIN\nSEND_ONCE remote key\nERROR\nDATA\n1\nunknown remote: remote\n", + "SEND_ONCE remote key", + False, + ["unknown remote: remote"], + None, + ), + ( + "BEGIN\nSEND_ONCE remote key\nSUCCESS\nDATA\n3\nraa\nblah\nbhal\n", + "SEND_ONCE remote key", + True, + ["raa", "blah", "bhal"], + None, + ), + ], +) +def test_parse_reply_packet(mock_lirc, reply_packet, command, success, data, exception): + if exception: + with pytest.raises(exception): + mock_lirc._Lirc__parse_reply_packet(reply_packet) + else: + response = mock_lirc._Lirc__parse_reply_packet(reply_packet) + assert response.success == success + assert response.command == command + assert response.data == data -- cgit v1.2.3 From b6c7abc311b10f5ee675100cb9420f7a83c88812 Mon Sep 17 00:00:00 2001 From: Eugene Triguba Date: Sun, 26 Jul 2020 18:24:47 -0500 Subject: Fix conftest and ignore tests The tests will need to be redone. --- tests/test_reply_packet_parser.py | 73 --------------------------------------- 1 file changed, 73 deletions(-) delete mode 100644 tests/test_reply_packet_parser.py (limited to 'tests/test_reply_packet_parser.py') diff --git a/tests/test_reply_packet_parser.py b/tests/test_reply_packet_parser.py deleted file mode 100644 index ff3c67c..0000000 --- a/tests/test_reply_packet_parser.py +++ /dev/null @@ -1,73 +0,0 @@ -import os - -import pytest - -from lirc import InvalidReplyPacketFormatError, LircSocketTimeoutError - - -@pytest.mark.parametrize( - "reply_packet", [b"BEGIN\nSEND_ONCE remote key\nSUCCESS\nEND\n"] -) -def test_read_reply_packet(mock_lirc_and_socket, reply_packet): - mock_lirc, mock_socket = mock_lirc_and_socket - mock_socket.recv.return_value = reply_packet - - retrieved_packet = mock_lirc._Lirc__read_reply_packet() - - mock_socket.recv.assert_called_with(256) - assert reply_packet == retrieved_packet.encode(mock_lirc._Lirc__encoding) - - -@pytest.mark.skipif( - os.environ.get("LIRC_RUN_LONG_TESTS") is None, reason="Test takes too long" -) -@pytest.mark.parametrize("reply_packet", [b"INVALID PACKET"]) -def test_read_reply_packet_socket_timeout(mock_lirc, reply_packet): - with pytest.raises(LircSocketTimeoutError): - mock_lirc._Lirc__socket.recv.return_value = reply_packet - mock_lirc._Lirc__read_reply_packet() - - -@pytest.mark.parametrize( - "reply_packet, command, success, data, exception", - [ - ( - "BEGIN\nSEND_ONCE remote key\nSUCCESS\nEND\n", - "SEND_ONCE remote key", - True, - [], - None, - ), - ("INVALID PACKET", "", False, [], None), - ( - "BEGIN\nSEND_ONCE remote key\nERROR\nINVALID\n", - "SEND_ONCE remote key", - False, - [], - InvalidReplyPacketFormatError, - ), - ( - "BEGIN\nSEND_ONCE remote key\nERROR\nDATA\n1\nunknown remote: remote\n", - "SEND_ONCE remote key", - False, - ["unknown remote: remote"], - None, - ), - ( - "BEGIN\nSEND_ONCE remote key\nSUCCESS\nDATA\n3\nraa\nblah\nbhal\n", - "SEND_ONCE remote key", - True, - ["raa", "blah", "bhal"], - None, - ), - ], -) -def test_parse_reply_packet(mock_lirc, reply_packet, command, success, data, exception): - if exception: - with pytest.raises(exception): - mock_lirc._Lirc__parse_reply_packet(reply_packet) - else: - response = mock_lirc._Lirc__parse_reply_packet(reply_packet) - assert response.success == success - assert response.command == command - assert response.data == data -- cgit v1.2.3 From dd1328a16f56bf9bdcf2f1d0a42a5561988232d7 Mon Sep 17 00:00:00 2001 From: Eugene Triguba Date: Sun, 26 Jul 2020 21:39:51 -0500 Subject: Remove DefaultAddress and DefaultSocket and rename test files --- tests/test_reply_packet_parser.py | 66 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 tests/test_reply_packet_parser.py (limited to 'tests/test_reply_packet_parser.py') diff --git a/tests/test_reply_packet_parser.py b/tests/test_reply_packet_parser.py new file mode 100644 index 0000000..86ae311 --- /dev/null +++ b/tests/test_reply_packet_parser.py @@ -0,0 +1,66 @@ +# import pytest +# +# from lirc import ( +# LircdCommandFailureError, +# LircdInvalidReplyPacketError, +# LircdSocketTimeoutError, +# ) +# from lirc.reply_packet_parser import ReplyPacketParser +# from lirc.utils import ENCODING +# +# +# @pytest.mark.parametrize( +# "reply_packet", [b"BEGIN\nSEND_ONCE remote key\nSUCCESS\nEND\n"] +# ) +# def test_read_reply_packet(mock_socket, reply_packet): +# mock_socket.recv.return_value = reply_packet +# parser = ReplyPacketParser(mock_socket) +# parser.read() +# +# retrieved_packet = parser.feed() +# +# mock_socket.recv.assert_called_with(ReplyPacketParser.BUFFER_LENGTH) +# assert reply_packet == retrieved_packet.encode(ENCODING) +# +# +# @pytest.mark.skip(reason="Not working") +# @pytest.mark.parametrize("reply_packet", [b"INVALID PACKET"]) +# def test_read_reply_packet_socket_timeout(mock_lirc, reply_packet): +# with pytest.raises(LircdSocketTimeoutError): +# mock_lirc.socket.recv.return_value = reply_packet +# ReplyPacketParser.read(mock_lirc.socket) +# +# +# @pytest.mark.parametrize( +# "reply_packet, data, exception", +# [ +# (b"BEGIN\nSEND_ONCE remote key\nSUCCESS\nEND\n", [], None,), +# # ("INVALID PACKET", [], LircdInvalidReplyPacketError), +# ( +# b"BEGIN\nSEND_ONCE remote key\nERROR\nINVALID\n", +# [], +# LircdInvalidReplyPacketError, +# ), +# ( +# b"BEGIN\nSEND_ONCE remote key\nERROR\nDATA\n1\nunknown remote: remote\n", +# ["unknown remote: remote"], +# LircdCommandFailureError, +# ), +# ( +# b"BEGIN\nSEND_ONCE remote key\nSUCCESS\nDATA\n3\nraa\nblah\nbhal\n", +# ["raa", "blah", "bhal"], +# None, +# ), +# ], +# ) +# def test_parse_reply_packet(mock_socket, reply_packet, data, exception): +# mock_socket.recv.return_value = reply_packet +# parser = ReplyPacketParser(mock_socket) +# +# if exception: +# with pytest.raises(exception): +# parser.read() +# parser.feed() +# else: +# parser.read() +# assert parser.feed() == data -- cgit v1.2.3