diff options
| author | Eugene Triguba <eugenetriguba@gmail.com> | 2024-01-08 21:17:48 -0500 |
|---|---|---|
| committer | Eugene Triguba <eugenetriguba@gmail.com> | 2024-01-08 21:17:48 -0500 |
| commit | 4fd3e07aea30cf86322704b1ac29eb9812cbcb79 (patch) | |
| tree | cbb5a35b5c9846c2dcda720ae21ddb4b0baf53e9 | |
| parent | Add shared test util package (diff) | |
| download | cli-4fd3e07aea30cf86322704b1ac29eb9812cbcb79.zip | |
Fix fs repo create and tweak tests
| -rw-r--r-- | internal/repositories/migration_fs_repo.go | 11 | ||||
| -rw-r--r-- | internal/repositories/migration_fs_repo_test.go | 95 |
2 files changed, 103 insertions, 3 deletions
diff --git a/internal/repositories/migration_fs_repo.go b/internal/repositories/migration_fs_repo.go index 2add285..d347176 100644 --- a/internal/repositories/migration_fs_repo.go +++ b/internal/repositories/migration_fs_repo.go @@ -42,14 +42,19 @@ func NewMigrationFsRepo(migrationsDirPath string) (*MigrationFsRepo, error) { } func (mr *MigrationFsRepo) Create(migration *models.Migration) error { - path := filepath.Join(mr.migrationsDirPath, mr.migrationDirname(migration)) + newMigrationDir := filepath.Join(mr.migrationsDirPath, mr.migrationDirname(migration)) - _, err := os.Create(filepath.Join(path, "upgrade.sql")) + err := os.Mkdir(newMigrationDir, 0755) if err != nil { return err } - _, err = os.Create(filepath.Join(path, "downgrade.sql")) + _, err = os.Create(filepath.Join(newMigrationDir, "upgrade.sql")) + if err != nil { + return err + } + + _, err = os.Create(filepath.Join(newMigrationDir, "downgrade.sql")) if err != nil { return err } diff --git a/internal/repositories/migration_fs_repo_test.go b/internal/repositories/migration_fs_repo_test.go new file mode 100644 index 0000000..b4b03e6 --- /dev/null +++ b/internal/repositories/migration_fs_repo_test.go @@ -0,0 +1,95 @@ +package repositories_test + +import ( + "fmt" + "os" + "path/filepath" + "testing" + "time" + + "github.com/eugenetriguba/bolt/internal/models" + "github.com/eugenetriguba/bolt/internal/repositories" + "gotest.tools/v3/assert" +) + +func assertFileExists(t *testing.T, path string) { + _, err := os.Stat(path) + assert.NilError(t, err) +} + +func TestNewMigrationFsRepoCreatesDirIfNotExists(t *testing.T) { + tempDir := t.TempDir() + migrationsDir := filepath.Join(tempDir, "migrations") + + _, err := repositories.NewMigrationFsRepo(migrationsDir) + assert.NilError(t, err) + + assertFileExists(t, migrationsDir) +} + +func TestNewMigrationFsRepoMigrationDirIsFile(t *testing.T) { + tempDir := t.TempDir() + migrationsDir := filepath.Join(tempDir, "migrations") + _, err := os.Create(migrationsDir) + assert.NilError(t, err) + + _, err = repositories.NewMigrationFsRepo(migrationsDir) + assert.ErrorContains(t, err, "is not a directory") +} + +func TestMigrationFsRepoCreate(t *testing.T) { + tempDir := t.TempDir() + repo, err := repositories.NewMigrationFsRepo(tempDir) + assert.NilError(t, err) + migration := models.NewMigration(time.Now(), "add users table") + + err = repo.Create(migration) + assert.NilError(t, err) + + migrationDirName := fmt.Sprintf("%s_add_users_table", migration.Version) + assertFileExists(t, filepath.Join(tempDir, migrationDirName)) + assertFileExists(t, filepath.Join(tempDir, migrationDirName, "upgrade.sql")) + assertFileExists(t, filepath.Join(tempDir, migrationDirName, "downgrade.sql")) +} + +func TestMigrationFsRepoReadUpgradeAndDowngradeScript(t *testing.T) { + tempDir := t.TempDir() + repo, err := repositories.NewMigrationFsRepo(tempDir) + assert.NilError(t, err) + + migration := models.NewMigration(time.Now(), "add users table") + err = repo.Create(migration) + assert.NilError(t, err) + + migrationDirName := fmt.Sprintf("%s_add_users_table", migration.Version) + expectedUpgradeScriptContents := []byte("CREATE TABLE users(id int PRIMARY KEY);") + os.WriteFile(filepath.Join(tempDir, migrationDirName, "upgrade.sql"), expectedUpgradeScriptContents, 0755) + expectedDowngradeScriptContents := []byte("DROP TABLE users;") + os.WriteFile(filepath.Join(tempDir, migrationDirName, "downgrade.sql"), expectedDowngradeScriptContents, 0755) + + upgradeScriptContents, err := repo.ReadUpgradeScript(migration) + assert.NilError(t, err) + assert.Equal(t, upgradeScriptContents, string(expectedUpgradeScriptContents)) + downgradeScriptContents, err := repo.ReadDowngradeScript(migration) + assert.NilError(t, err) + assert.Equal(t, downgradeScriptContents, string(expectedDowngradeScriptContents)) +} + +func TestMigrationFsRepo_List(t *testing.T) { + tempDir := t.TempDir() + repo, err := repositories.NewMigrationFsRepo(tempDir) + assert.NilError(t, err) + + migration1 := models.NewMigration(time.Date(2020, 10, 12, 1, 1, 1, 1, time.UTC), "migration_1") + migration2 := models.NewMigration(time.Date(2022, 10, 12, 1, 1, 1, 1, time.UTC), "migration_2") + err = repo.Create(migration1) + assert.NilError(t, err) + repo.Create(migration2) + assert.NilError(t, err) + + migrations, err := repo.List() + assert.NilError(t, err) + assert.Equal(t, len(migrations), 2) + assert.DeepEqual(t, migrations[migration1.Version], migration1) + assert.DeepEqual(t, migrations[migration2.Version], migration2) +} |