aboutsummaryrefslogtreecommitdiffstats
path: root/internal/repositories
diff options
context:
space:
mode:
authorEugene Triguba <eugenetriguba@gmail.com>2024-03-23 09:12:52 -0400
committerEugene Triguba <eugenetriguba@gmail.com>2024-03-23 09:12:52 -0400
commit99c4818223ac87eee30bb1ecbf96dbdd32a31a1f (patch)
tree0b40ba322d1d42a8d17aa182aac78e3822ee6895 /internal/repositories
parentAdd workflow to bump homebrew formula version (diff)
downloadcli-99c4818223ac87eee30bb1ecbf96dbdd32a31a1f.zip
Add handling of duplicate local migration versions
Diffstat (limited to 'internal/repositories')
-rw-r--r--internal/repositories/migration_fs_repo.go25
-rw-r--r--internal/repositories/migration_fs_repo_test.go28
2 files changed, 49 insertions, 4 deletions
diff --git a/internal/repositories/migration_fs_repo.go b/internal/repositories/migration_fs_repo.go
index 0ded9d0..a4030a5 100644
--- a/internal/repositories/migration_fs_repo.go
+++ b/internal/repositories/migration_fs_repo.go
@@ -13,6 +13,8 @@ import (
"github.com/eugenetriguba/bolt/internal/sqlparse"
)
+var ErrMigrationVersionConflict = errors.New("migration version conflict")
+
type ErrIsNotDir struct {
path string
}
@@ -86,6 +88,15 @@ func (mr migrationFsRepo) List() (map[string]*models.Migration, error) {
if err != nil {
return nil, err
}
+ _, exists := migrations[migration.Version]
+ if exists {
+ return nil, fmt.Errorf(
+ "%w: a local migration file with version %s already exists",
+ ErrMigrationVersionConflict,
+ migration.Version,
+ )
+ }
+
migrations[migration.Version] = migration
}
@@ -110,7 +121,9 @@ func dirEntryToMigration(entry fs.DirEntry) (*models.Migration, error) {
}, nil
}
-func (mr migrationFsRepo) ReadUpgradeScript(migration *models.Migration) (sqlparse.MigrationScript, error) {
+func (mr migrationFsRepo) ReadUpgradeScript(
+ migration *models.Migration,
+) (sqlparse.MigrationScript, error) {
scriptPath := filepath.Join(
mr.migrationsDirPath,
migration.Name()+".sql",
@@ -130,10 +143,16 @@ func (mr migrationFsRepo) ReadDowngradeScript(
return downgradeScript, err
}
-func (mr migrationFsRepo) getMigrationScripts(scriptPath string) (sqlparse.MigrationScript, sqlparse.MigrationScript, error) {
+func (mr migrationFsRepo) getMigrationScripts(
+ scriptPath string,
+) (sqlparse.MigrationScript, sqlparse.MigrationScript, error) {
scriptContents, err := mr.readScriptContents(scriptPath)
if err != nil {
- return sqlparse.MigrationScript{}, sqlparse.MigrationScript{}, fmt.Errorf("unable to read %s script: %w", scriptPath, err)
+ return sqlparse.MigrationScript{}, sqlparse.MigrationScript{}, fmt.Errorf(
+ "unable to read %s script: %w",
+ scriptPath,
+ err,
+ )
}
sqlParser := sqlparse.NewSqlParser()
return sqlParser.Parse(strings.NewReader(scriptContents))
diff --git a/internal/repositories/migration_fs_repo_test.go b/internal/repositories/migration_fs_repo_test.go
index 96d48a0..938cc2b 100644
--- a/internal/repositories/migration_fs_repo_test.go
+++ b/internal/repositories/migration_fs_repo_test.go
@@ -69,7 +69,11 @@ func TestCreate_FailsToCreateMigration(t *testing.T) {
)
assert.Nil(t, err)
migration := models.NewTimestampMigration(time.Now(), "add users table")
- _, err = os.OpenFile(filepath.Join(tempDir, fmt.Sprintf("%s.sql", migration.Name())), os.O_CREATE, 0000)
+ _, err = os.OpenFile(
+ filepath.Join(tempDir, fmt.Sprintf("%s.sql", migration.Name())),
+ os.O_CREATE,
+ 0000,
+ )
assert.Nil(t, err)
err = repo.Create(migration)
@@ -205,3 +209,25 @@ func TestList_InvalidMigrationName(t *testing.T) {
"expected a migration directory of the format <version>_<message>",
)
}
+
+func TestList_DuplicateMigrationVersion(t *testing.T) {
+ migrationsDir := filepath.Join(t.TempDir(), "migrations")
+ migrationsConfig := configloader.MigrationsConfig{DirectoryPath: migrationsDir}
+ repo, err := repositories.NewMigrationFsRepo(&migrationsConfig)
+ assert.Nil(t, err)
+ migration1 := models.NewSequentialMigration(1, "migration_1")
+ migration2 := models.NewSequentialMigration(1, "migration_2")
+ err = repo.Create(migration1)
+ assert.Nil(t, err)
+ repo.Create(migration2)
+ assert.Nil(t, err)
+
+ _, err = repo.List()
+
+ assert.ErrorIs(t, err, repositories.ErrMigrationVersionConflict)
+ assert.ErrorContains(
+ t,
+ err,
+ "a local migration file with version 001 already exists",
+ )
+}