aboutsummaryrefslogtreecommitdiffstats
path: root/internal/repositories
diff options
context:
space:
mode:
authorEugene Triguba <eugenetriguba@gmail.com>2024-03-02 11:04:00 -0500
committerEugene Triguba <eugenetriguba@gmail.com>2024-03-02 11:04:00 -0500
commita37df93853def914dbda165cdcf09ae8e0305ec3 (patch)
tree41fb3a459db99d1f0ec2ed2e00d4ca580a5d0c46 /internal/repositories
parentimprove wording (diff)
downloadcli-a37df93853def914dbda165cdcf09ae8e0305ec3.zip
Remove Latest() from migration fs repo in favor of using List on service
Diffstat (limited to 'internal/repositories')
-rw-r--r--internal/repositories/migration_fs_repo.go18
-rw-r--r--internal/repositories/migration_fs_repo_test.go26
2 files changed, 0 insertions, 44 deletions
diff --git a/internal/repositories/migration_fs_repo.go b/internal/repositories/migration_fs_repo.go
index 9d6c3aa..e535013 100644
--- a/internal/repositories/migration_fs_repo.go
+++ b/internal/repositories/migration_fs_repo.go
@@ -26,7 +26,6 @@ func (e *ErrIsNotDir) Error() string {
type MigrationFsRepo interface {
Create(migration *models.Migration) error
List() (map[string]*models.Migration, error)
- Latest() (*models.Migration, error)
ReadUpgradeScript(migration *models.Migration) (string, error)
ReadDowngradeScript(migration *models.Migration) (string, error)
}
@@ -82,23 +81,6 @@ func (mr migrationFsRepo) Create(migration *models.Migration) error {
return nil
}
-func (mr migrationFsRepo) Latest() (*models.Migration, error) {
- // TODO: ReadDir returns migrations sorted by filename.
- // To be correct, it seems like we will need to sort these
- // migrations by the version style that is configured and then
- // grab the latest.
- entries, err := os.ReadDir(mr.migrationsDirPath)
- if err != nil {
- return nil, err
- }
-
- if len(entries) > 0 {
- return dirEntryToMigration(entries[len(entries)-1])
- }
-
- return nil, nil
-}
-
func (mr migrationFsRepo) List() (map[string]*models.Migration, error) {
entries, err := os.ReadDir(mr.migrationsDirPath)
if err != nil {
diff --git a/internal/repositories/migration_fs_repo_test.go b/internal/repositories/migration_fs_repo_test.go
index d10bddc..32de193 100644
--- a/internal/repositories/migration_fs_repo_test.go
+++ b/internal/repositories/migration_fs_repo_test.go
@@ -208,29 +208,3 @@ func TestList_InvalidMigrationName(t *testing.T) {
"expected a migration directory of the format <version>_<message>",
)
}
-
-func TestLatest_DirDoesNotExist(t *testing.T) {
- migrationsDir := filepath.Join(t.TempDir(), "migrations")
- migrationsConfig := configloader.MigrationsConfig{DirectoryPath: migrationsDir}
- repo, err := repositories.NewMigrationFsRepo(&migrationsConfig)
- assert.Nil(t, err)
- err = os.RemoveAll(migrationsDir)
- assert.Nil(t, err)
-
- _, err = repo.Latest()
-
- assert.NotNil(t, err)
- assert.ErrorContains(t, err, "no such file or directory")
-}
-
-func TestLatest_NoMigrations(t *testing.T) {
- migrationsDir := filepath.Join(t.TempDir(), "migrations")
- migrationsConfig := configloader.MigrationsConfig{DirectoryPath: migrationsDir}
- repo, err := repositories.NewMigrationFsRepo(&migrationsConfig)
- assert.Nil(t, err)
-
- latestMigration, err := repo.Latest()
-
- assert.Nil(t, err)
- assert.Nil(t, latestMigration)
-}