aboutsummaryrefslogtreecommitdiffstats
path: root/internal/repositories
diff options
context:
space:
mode:
authorEugene Triguba <eugenetriguba@gmail.com>2024-01-19 23:27:27 -0500
committerEugene Triguba <eugenetriguba@gmail.com>2024-01-19 23:27:27 -0500
commitdb7de4b31b1836abed822077840665639f0d66da (patch)
treed58769374a346778ffff35e6cf56a27e6067f237 /internal/repositories
parentFix typo in output when a user has no migrations (diff)
downloadcli-db7de4b31b1836abed822077840665639f0d66da.zip
Add ability to use sequential or timestamp-based versions
Diffstat (limited to 'internal/repositories')
-rw-r--r--internal/repositories/migration_db_repo_test.go10
-rw-r--r--internal/repositories/migration_fs_repo.go46
-rw-r--r--internal/repositories/migration_fs_repo_test.go8
3 files changed, 43 insertions, 21 deletions
diff --git a/internal/repositories/migration_db_repo_test.go b/internal/repositories/migration_db_repo_test.go
index 55b8eb2..dc635b0 100644
--- a/internal/repositories/migration_db_repo_test.go
+++ b/internal/repositories/migration_db_repo_test.go
@@ -131,7 +131,7 @@ func TestMigrationDBRepo_Apply(t *testing.T) {
repo, err := repositories.NewMigrationDBRepo(db)
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "test")
+ migration := models.NewTimestampMigration(time.Now(), "test")
err = repo.Apply(`CREATE TABLE tmp(id INT NOT NULL PRIMARY KEY)`, migration)
assert.NilError(t, err)
assert.Equal(t, migration.Applied, true)
@@ -158,7 +158,7 @@ func TestMigrationDBRepo_Revert(t *testing.T) {
_, err = db.Exec(`CREATE TABLE tmp(id INT NOT NULL PRIMARY KEY)`)
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "test")
+ migration := models.NewTimestampMigration(time.Now(), "test")
_, err = db.Exec(
`INSERT INTO bolt_migrations(version) VALUES ($1);`,
migration.Version,
@@ -194,7 +194,7 @@ func TestMigrationDBRepo_ApplyAndRevertWithoutTransaction(t *testing.T) {
_, err = db.Exec("CREATE TABLE tmp(id INT PRIMARY KEY, id2 INT, id3 INT)")
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "test")
+ migration := models.NewTimestampMigration(time.Now(), "test")
// CREATE INDEX CONCURRENTLY cannot run inside a transaction.
err = repo.Apply(
`-- bolt: no-transaction\CREATE INDEX CONCURRENTLY i1 ON tmp(id2);`,
@@ -215,7 +215,7 @@ func TestMigrationDBRepo_ApplyMalformedSql(t *testing.T) {
db := bolttest.NewTestDB(t, "postgres")
repo, err := repositories.NewMigrationDBRepo(db)
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "test")
+ migration := models.NewTimestampMigration(time.Now(), "test")
err = repo.Apply("this is not SQL", migration)
assert.ErrorContains(t, err, "syntax error")
@@ -230,7 +230,7 @@ func TestMigrationDBRepo_RevertMalformedSql(t *testing.T) {
db := bolttest.NewTestDB(t, "postgres")
repo, err := repositories.NewMigrationDBRepo(db)
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "test")
+ migration := models.NewTimestampMigration(time.Now(), "test")
migration.Applied = true
err = repo.Revert("this is not SQL", migration)
diff --git a/internal/repositories/migration_fs_repo.go b/internal/repositories/migration_fs_repo.go
index 5478b5c..65afe5f 100644
--- a/internal/repositories/migration_fs_repo.go
+++ b/internal/repositories/migration_fs_repo.go
@@ -3,6 +3,7 @@ package repositories
import (
"errors"
"fmt"
+ "io/fs"
"os"
"path/filepath"
"strings"
@@ -87,6 +88,19 @@ func (mr *MigrationFsRepo) Get(version string) (*models.Migration, error) {
return migration, nil
}
+func (mr *MigrationFsRepo) Latest() (*models.Migration, error) {
+ entries, err := os.ReadDir(mr.migrationsDirPath)
+ if err != nil {
+ return nil, err
+ }
+
+ if len(entries) > 0 {
+ return dirEntryToMigration(entries[len(entries)-1])
+ }
+
+ return nil, nil
+}
+
func (mr *MigrationFsRepo) List() (map[string]*models.Migration, error) {
entries, err := os.ReadDir(mr.migrationsDirPath)
if err != nil {
@@ -95,24 +109,32 @@ func (mr *MigrationFsRepo) List() (map[string]*models.Migration, error) {
var migrations = make(map[string]*models.Migration)
for _, entry := range entries {
- parts := strings.SplitN(entry.Name(), "_", 2)
- if len(parts) != 2 {
- return nil, fmt.Errorf(
- "%s is an invalid migration name: expected a "+
- "migration directory of the format <version>_<message>",
- entry.Name(),
- )
- }
- migrations[parts[0]] = &models.Migration{
- Version: parts[0],
- Message: parts[1],
- Applied: false,
+ migration, err := dirEntryToMigration(entry)
+ if err != nil {
+ return nil, err
}
+ migrations[migration.Version] = migration
}
return migrations, nil
}
+func dirEntryToMigration(entry fs.DirEntry) (*models.Migration, error) {
+ parts := strings.SplitN(entry.Name(), "_", 2)
+ if len(parts) != 2 {
+ return nil, fmt.Errorf(
+ "%s is an invalid migration name: expected a "+
+ "migration directory of the format <version>_<message>",
+ entry.Name(),
+ )
+ }
+ return &models.Migration{
+ Version: parts[0],
+ Message: parts[1],
+ Applied: false,
+ }, nil
+}
+
func (mr *MigrationFsRepo) ReadUpgradeScript(
migration *models.Migration,
) (string, error) {
diff --git a/internal/repositories/migration_fs_repo_test.go b/internal/repositories/migration_fs_repo_test.go
index 8fdcd8f..b1659fd 100644
--- a/internal/repositories/migration_fs_repo_test.go
+++ b/internal/repositories/migration_fs_repo_test.go
@@ -45,7 +45,7 @@ func TestMigrationFsRepoCreate(t *testing.T) {
migrationsConfig := configloader.MigrationsConfig{DirectoryPath: tempDir}
repo, err := repositories.NewMigrationFsRepo(&migrationsConfig)
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "add users table")
+ migration := models.NewTimestampMigration(time.Now(), "add users table")
err = repo.Create(migration)
assert.NilError(t, err)
@@ -62,7 +62,7 @@ func TestMigrationFsRepoReadUpgradeAndDowngradeScript(t *testing.T) {
repo, err := repositories.NewMigrationFsRepo(&migrationsConfig)
assert.NilError(t, err)
- migration := models.NewMigration(time.Now(), "add users table")
+ migration := models.NewTimestampMigration(time.Now(), "add users table")
err = repo.Create(migration)
assert.NilError(t, err)
@@ -94,11 +94,11 @@ func TestMigrationFsRepo_List(t *testing.T) {
repo, err := repositories.NewMigrationFsRepo(&migrationsConfig)
assert.NilError(t, err)
- migration1 := models.NewMigration(
+ migration1 := models.NewTimestampMigration(
time.Date(2020, 10, 12, 1, 1, 1, 1, time.UTC),
"migration_1",
)
- migration2 := models.NewMigration(
+ migration2 := models.NewTimestampMigration(
time.Date(2022, 10, 12, 1, 1, 1, 1, time.UTC),
"migration_2",
)