diff options
| author | Eugene Triguba <hello@eugenetriguba.com> | 2025-10-18 10:43:39 -0400 |
|---|---|---|
| committer | Eugene Triguba <hello@eugenetriguba.com> | 2025-11-26 11:46:57 -0500 |
| commit | e5658d1f61415054029b66cd2f703f1f40138460 (patch) | |
| tree | c609e209f4cebc62dd985d1b773558f47eb73bf6 /internal/repositories | |
| parent | Add is-branch main check for docs deployment (diff) | |
| download | cli-e5658d1f61415054029b66cd2f703f1f40138460.zip | |
Add support for migration dependencies
Diffstat (limited to 'internal/repositories')
| -rw-r--r-- | internal/repositories/migration_fs_repo.go | 49 | ||||
| -rw-r--r-- | internal/repositories/migration_fs_repo_test.go | 10 |
2 files changed, 50 insertions, 9 deletions
diff --git a/internal/repositories/migration_fs_repo.go b/internal/repositories/migration_fs_repo.go index 3923b69..b300dad 100644 --- a/internal/repositories/migration_fs_repo.go +++ b/internal/repositories/migration_fs_repo.go @@ -69,7 +69,17 @@ func (mr migrationFsRepo) Create(migration *models.Migration) error { if err != nil { return fmt.Errorf("unable to create file at %s: %w", newMigrationPath, err) } - _, err = file.WriteString("-- migrate:up\n\n-- migrate:down\n") + defer file.Close() + + var template strings.Builder + if len(migration.Dependencies) > 0 { + template.WriteString("-- depends: ") + template.WriteString(strings.Join(migration.Dependencies, ", ")) + template.WriteString("\n") + } + template.WriteString("-- migrate:up\n\n-- migrate:down\n") + + _, err = file.WriteString(template.String()) if err != nil { return fmt.Errorf("unable to write template to new migration script: %w", err) } @@ -84,7 +94,7 @@ func (mr migrationFsRepo) List() (map[string]*models.Migration, error) { var migrations = make(map[string]*models.Migration, 0) for _, entry := range entries { - migration, err := dirEntryToMigration(entry) + migration, err := mr.dirEntryToMigration(entry) if err != nil { return nil, err } @@ -96,14 +106,13 @@ func (mr migrationFsRepo) List() (map[string]*models.Migration, error) { migration.Version, ) } - migrations[migration.Version] = migration } return migrations, nil } -func dirEntryToMigration(entry fs.DirEntry) (*models.Migration, error) { +func (mr migrationFsRepo) dirEntryToMigration(entry fs.DirEntry) (*models.Migration, error) { parts := strings.SplitN(entry.Name(), "_", 2) if len(parts) != 2 { return nil, fmt.Errorf( @@ -114,11 +123,35 @@ func dirEntryToMigration(entry fs.DirEntry) (*models.Migration, error) { } version := parts[0] message := strings.TrimSuffix(parts[1], filepath.Ext(parts[1])) // Remove .sql - return &models.Migration{ + migration := &models.Migration{ Version: version, Message: message, Applied: false, - }, nil + } + + scriptPath := filepath.Join(mr.migrationsDirPath, entry.Name()) + dependencies, err := mr.parseDependenciesFromFile(scriptPath) + if err != nil { + return nil, fmt.Errorf("unable to parse dependencies from %s: %w", entry.Name(), err) + } + migration.Dependencies = dependencies + + return migration, nil +} + +func (mr migrationFsRepo) parseDependenciesFromFile(scriptPath string) ([]string, error) { + scriptContents, err := mr.readScriptContents(scriptPath) + if err != nil { + return nil, err + } + + sqlParser := sqlparse.NewSqlParser() + migration, err := sqlParser.Parse(strings.NewReader(scriptContents)) + if err != nil { + return nil, err + } + + return migration.Dependencies, nil } func (mr migrationFsRepo) ReadUpgradeScript( @@ -155,7 +188,8 @@ func (mr migrationFsRepo) getMigrationScripts( ) } sqlParser := sqlparse.NewSqlParser() - return sqlParser.Parse(strings.NewReader(scriptContents)) + migration, err := sqlParser.Parse(strings.NewReader(scriptContents)) + return migration.UpgradeScript, migration.DowngradeScript, err } func (mr migrationFsRepo) readScriptContents(scriptPath string) (string, error) { @@ -163,6 +197,5 @@ func (mr migrationFsRepo) readScriptContents(scriptPath string) (string, error) if err != nil { return "", err } - return string(contents), nil } diff --git a/internal/repositories/migration_fs_repo_test.go b/internal/repositories/migration_fs_repo_test.go index 7625c06..facfd34 100644 --- a/internal/repositories/migration_fs_repo_test.go +++ b/internal/repositories/migration_fs_repo_test.go @@ -55,11 +55,17 @@ func TestCreate_SuccessfullyCreated(t *testing.T) { repo, err := repositories.NewMigrationFsRepo(&migrationsConfig) assert.Nil(t, err) migration := models.NewTimestampMigration(time.Now(), "add users table") + migration.Dependencies = append(migration.Dependencies, "001") err = repo.Create(migration) assert.Nil(t, err) - assertFileExists(t, filepath.Join(tempDir, fmt.Sprintf("%s.sql", migration.Name()))) + path := filepath.Join(tempDir, fmt.Sprintf("%s.sql", migration.Name())) + assertFileExists(t, path) + contents, err := os.ReadFile(path) + assert.Nil(t, err) + assert.Equal(t, "-- depends: 001\n-- migrate:up\n\n-- migrate:down\n", string(contents)) + } func TestCreate_FailsToCreateMigration(t *testing.T) { @@ -162,10 +168,12 @@ func TestList_Success(t *testing.T) { time.Date(2020, 10, 12, 1, 1, 1, 1, time.UTC), "migration_1", ) + migration1.Dependencies = []string{"001", "002"} migration2 := models.NewTimestampMigration( time.Date(2022, 10, 12, 1, 1, 1, 1, time.UTC), "migration_2", ) + migration2.Dependencies = []string{"003"} err = repo.Create(migration1) assert.Nil(t, err) repo.Create(migration2) |