diff options
Diffstat (limited to 'internal/services/migration_test.go')
| -rw-r--r-- | internal/services/migration_test.go | 257 |
1 files changed, 16 insertions, 241 deletions
diff --git a/internal/services/migration_test.go b/internal/services/migration_test.go index 09d33a3..0496299 100644 --- a/internal/services/migration_test.go +++ b/internal/services/migration_test.go @@ -3,10 +3,9 @@ package services import ( "errors" "testing" - "time" "git.sr.ht/~eugenetriguba/bolt/internal/bolttest" - "git.sr.ht/~eugenetriguba/bolt/internal/configloader" + "git.sr.ht/~eugenetriguba/bolt/internal/models" "git.sr.ht/~eugenetriguba/bolt/internal/sqlparse" "git.sr.ht/~eugenetriguba/checkmate/assert" @@ -17,7 +16,6 @@ func TestListMigrations(t *testing.T) { type test struct { localFilesystemMigrations []*models.Migration remoteAppliedMigrations []*models.Migration - cfg configloader.Config sortOrder sortOrder expectedMigrations []*models.Migration } @@ -27,13 +25,8 @@ func TestListMigrations(t *testing.T) { { localFilesystemMigrations: []*models.Migration{}, remoteAppliedMigrations: []*models.Migration{}, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, - sortOrder: SortOrderAsc, - expectedMigrations: []*models.Migration{}, + sortOrder: SortOrderAsc, + expectedMigrations: []*models.Migration{}, }, // Ensure one local fs migration shows up as expected. { @@ -41,12 +34,7 @@ func TestListMigrations(t *testing.T) { {Version: "001", Applied: false}, }, remoteAppliedMigrations: []*models.Migration{}, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, - sortOrder: SortOrderAsc, + sortOrder: SortOrderAsc, expectedMigrations: []*models.Migration{ {Version: "001", Applied: false}, }, @@ -60,11 +48,6 @@ func TestListMigrations(t *testing.T) { remoteAppliedMigrations: []*models.Migration{ {Version: "001", Applied: true}, }, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, sortOrder: SortOrderAsc, expectedMigrations: []*models.Migration{ {Version: "001", Applied: true}, @@ -77,11 +60,6 @@ func TestListMigrations(t *testing.T) { remoteAppliedMigrations: []*models.Migration{ {Version: "001", Applied: true}, }, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, sortOrder: SortOrderAsc, expectedMigrations: []*models.Migration{}, }, @@ -97,12 +75,7 @@ func TestListMigrations(t *testing.T) { {Version: "001"}, }, remoteAppliedMigrations: []*models.Migration{}, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, - sortOrder: SortOrderAsc, + sortOrder: SortOrderAsc, expectedMigrations: []*models.Migration{ {Version: "001"}, {Version: "110"}, @@ -125,12 +98,7 @@ func TestListMigrations(t *testing.T) { {Version: "20000"}, }, remoteAppliedMigrations: []*models.Migration{}, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, - sortOrder: SortOrderDesc, + sortOrder: SortOrderDesc, expectedMigrations: []*models.Migration{ {Version: "20000"}, {Version: "10000"}, @@ -141,62 +109,6 @@ func TestListMigrations(t *testing.T) { {Version: "001"}, }, }, - // Ensure that migrations are sorted in asc order for timestamp migrations - { - localFilesystemMigrations: []*models.Migration{ - {Version: "20080509220905"}, - {Version: "20080509220405"}, - {Version: "20080509150405"}, - {Version: "20080502150405"}, - {Version: "20080102150405"}, - {Version: "20070102150405"}, - {Version: "20060102150405"}, - }, - remoteAppliedMigrations: []*models.Migration{}, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleTimestamp, - }, - }, - sortOrder: SortOrderAsc, - expectedMigrations: []*models.Migration{ - {Version: "20060102150405"}, - {Version: "20070102150405"}, - {Version: "20080102150405"}, - {Version: "20080502150405"}, - {Version: "20080509150405"}, - {Version: "20080509220405"}, - {Version: "20080509220905"}, - }, - }, - // Ensure that migrations are sorted in desc order for timestamp migrations - { - localFilesystemMigrations: []*models.Migration{ - {Version: "20060102150405"}, - {Version: "20070102150405"}, - {Version: "20080102150405"}, - {Version: "20080502150405"}, - {Version: "20080509150405"}, - {Version: "20080509220405"}, - {Version: "20080509220905"}, - }, - remoteAppliedMigrations: []*models.Migration{}, - cfg: configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleTimestamp, - }, - }, - sortOrder: SortOrderDesc, - expectedMigrations: []*models.Migration{ - {Version: "20080509220905"}, - {Version: "20080509220405"}, - {Version: "20080509150405"}, - {Version: "20080502150405"}, - {Version: "20080102150405"}, - {Version: "20070102150405"}, - {Version: "20060102150405"}, - }, - }, } for _, tc := range tests { @@ -225,7 +137,6 @@ func TestListMigrations(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - tc.cfg, bolttest.NullOutputter{}, ) migrations, err := svc.ListMigrations(tc.sortOrder) @@ -253,7 +164,6 @@ func TestListMigrations_FsRepoListError(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) migrations, err := svc.ListMigrations(SortOrderAsc) @@ -281,7 +191,6 @@ func TestListMigrations_DbRepoListError(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) migrations, err := svc.ListMigrations(SortOrderAsc) @@ -293,31 +202,18 @@ func TestListMigrations_DbRepoListError(t *testing.T) { func TestListMigrations_ParseErrDuringSort(t *testing.T) { type test struct { - m1 models.Migration - m2 models.Migration - versionStyle configloader.VersionStyle + m1 models.Migration + m2 models.Migration } tests := []test{ { - m1: models.Migration{Version: "abc"}, - m2: models.Migration{Version: "123"}, - versionStyle: configloader.VersionStyleSequential, - }, - { - m1: models.Migration{Version: "123"}, - m2: models.Migration{Version: "abc"}, - versionStyle: configloader.VersionStyleSequential, - }, - { - m1: models.Migration{Version: "20060102150405"}, - m2: models.Migration{Version: "abc"}, - versionStyle: configloader.VersionStyleTimestamp, + m1: models.Migration{Version: "abc"}, + m2: models.Migration{Version: "123"}, }, { - m1: models.Migration{Version: "abc"}, - m2: models.Migration{Version: "20060102150405"}, - versionStyle: configloader.VersionStyleTimestamp, + m1: models.Migration{Version: "123"}, + m2: models.Migration{Version: "abc"}, }, } @@ -341,11 +237,6 @@ func TestListMigrations_ParseErrDuringSort(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: tc.versionStyle, - }, - }, bolttest.NullOutputter{}, ) migrations, err := svc.ListMigrations(SortOrderAsc) @@ -356,38 +247,7 @@ func TestListMigrations_ParseErrDuringSort(t *testing.T) { } } -func TestCreateMigration_VersionStyleTimestamp(t *testing.T) { - migrationFsRepo := &bolttest.MockMigrationFsRepo{ - CreateReturnValue: bolttest.CreateReturnValue{ - Err: nil, - }, - } - migrationDbRepo := &bolttest.MockMigrationDBRepo{} - svc := NewMigrationService( - migrationDbRepo, - migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleTimestamp, - }, - }, - bolttest.NullOutputter{}, - ) - - beforeCreateTs := time.Now().Add(30 * -time.Second) - migration, err := svc.CreateMigration("new migration") - afterCreateTs := time.Now().Add(30 * time.Second) - - assert.Nil(t, err) - version, err := time.ParseInLocation("20060102150405", migration.Version, time.Local) - assert.Nil(t, err) - check.True(t, beforeCreateTs.Before(version)) - check.True(t, afterCreateTs.After(version)) - check.Equal(t, migration.Message, "new migration") - check.Equal(t, migration.Applied, false) -} - -func TestCreateMigration_VersionStyleSequential(t *testing.T) { +func TestCreateMigration(t *testing.T) { migrationFsRepo := &bolttest.MockMigrationFsRepo{ CreateReturnValue: bolttest.CreateReturnValue{ Err: nil, @@ -397,11 +257,6 @@ func TestCreateMigration_VersionStyleSequential(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -422,11 +277,6 @@ func TestCreateMigration_NilDbRepo(t *testing.T) { svc := NewMigrationService( nil, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -449,11 +299,6 @@ func TestCreateMigration_CreateErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -474,11 +319,6 @@ func TestCreateMigration_LatestErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -488,7 +328,7 @@ func TestCreateMigration_LatestErr(t *testing.T) { assert.Nil(t, migration) } -func TestCreateMigration_SequentialVersionIncrements(t *testing.T) { +func TestCreateMigration_VersionIncrements(t *testing.T) { migrationFsRepo := &bolttest.MockMigrationFsRepo{ ListReturnValue: bolttest.ListReturnValue{ Migrations: map[string]*models.Migration{ @@ -504,11 +344,6 @@ func TestCreateMigration_SequentialVersionIncrements(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -518,7 +353,7 @@ func TestCreateMigration_SequentialVersionIncrements(t *testing.T) { assert.Equal(t, migration.Version, "002") } -func TestCreateMigration_SequentialVersionIncrementsLatestVersion(t *testing.T) { +func TestCreateMigration_VersionIncrementsLatestVersion(t *testing.T) { migrationFsRepo := &bolttest.MockMigrationFsRepo{ ListReturnValue: bolttest.ListReturnValue{ Migrations: map[string]*models.Migration{ @@ -536,11 +371,6 @@ func TestCreateMigration_SequentialVersionIncrementsLatestVersion(t *testing.T) svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -550,7 +380,7 @@ func TestCreateMigration_SequentialVersionIncrementsLatestVersion(t *testing.T) assert.Equal(t, migration.Version, "004") } -func TestCreateMigration_SequentialVersionIncrementsParsingErr(t *testing.T) { +func TestCreateMigration_VersionIncrementsParsingErr(t *testing.T) { migrationFsRepo := &bolttest.MockMigrationFsRepo{ ListReturnValue: bolttest.ListReturnValue{ Migrations: map[string]*models.Migration{ @@ -566,11 +396,6 @@ func TestCreateMigration_SequentialVersionIncrementsParsingErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -599,7 +424,6 @@ func TestApplyMigration_WithTransaction(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -629,7 +453,6 @@ func TestApplyMigration_WithoutTransaction(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -653,7 +476,6 @@ func TestApplyMigration_ReadUpgradeScriptErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -680,7 +502,6 @@ func TestApplyMigration_ApplyWithTxErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -707,7 +528,6 @@ func TestApplyMigration_ApplyErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -727,7 +547,6 @@ func TestApplyAllMigrations_ListMigrationsErr(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -751,11 +570,6 @@ func TestApplyAllMigrations_AppliesNothingIfAllApplied(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -784,11 +598,6 @@ func TestApplyAllMigrations_ApplyMigrationErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -810,7 +619,6 @@ func TestApplyUpToVersion_ListMigrationsErr(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -832,7 +640,6 @@ func TestApplyUpToVersion_TargetMigrationNotFound(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -854,7 +661,6 @@ func TestApplyUpToVersion_TargetMigrationAlreadyApplied(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -880,7 +686,6 @@ func TestApplyUpToVersion_ApplyMigrationErr(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -904,11 +709,6 @@ func TestApplyUpToVersion_AppliesMigrations(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -937,7 +737,6 @@ func TestRevertMigration_WithTransaction(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -966,7 +765,6 @@ func TestRevertMigration_WithoutTransaction(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -989,7 +787,6 @@ func TestRevertMigration_ReadUpgradeScriptErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1016,7 +813,6 @@ func TestRevertMigration_RevertWithTxErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1043,7 +839,6 @@ func TestRevertMigration_RevertErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1063,7 +858,6 @@ func TestRevertDownToVersion_ListMigrationsErr(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1085,7 +879,6 @@ func TestRevertDownToVersion_TargetMigrationNotFound(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1107,7 +900,6 @@ func TestRevertDownToVersion_TargetMigrationNotApplied(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1133,7 +925,6 @@ func TestRevertDownToVersion_RevertMigrationErr(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1157,11 +948,6 @@ func TestRevertDownToVersion_RevertsMigrations(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -1182,7 +968,6 @@ func TestRevertAllMigrations_ListMigrationsErr(t *testing.T) { svc := NewMigrationService( &bolttest.MockMigrationDBRepo{}, migrationFsRepo, - configloader.Config{}, bolttest.NullOutputter{}, ) @@ -1206,11 +991,6 @@ func TestRevertAllMigrations_RevertsNothingIfNoneApplied(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) @@ -1239,11 +1019,6 @@ func TestRevertAllMigrations_RevertMigrationErr(t *testing.T) { svc := NewMigrationService( migrationDbRepo, migrationFsRepo, - configloader.Config{ - Migrations: configloader.MigrationsConfig{ - VersionStyle: configloader.VersionStyleSequential, - }, - }, bolttest.NullOutputter{}, ) |