diff options
| author | Eugene Triguba <eugenetriguba@gmail.com> | 2025-07-12 12:28:57 -0400 |
|---|---|---|
| committer | Eugene Triguba <eugenetriguba@gmail.com> | 2025-07-12 12:28:57 -0400 |
| commit | 62c324f89216da1c311c8225f6c9087e441734de (patch) | |
| tree | 89b60475d217bb1bbc9de91d43b243055124b2e5 | |
| parent | Remove unnecesary if statement and fix memset (diff) | |
| download | cli-62c324f89216da1c311c8225f6c9087e441734de.zip | |
Simplify justify function and add additional read_word test
| -rw-r--r-- | src/main.c | 6 | ||||
| -rw-r--r-- | tests/test_word.c | 19 |
2 files changed, 19 insertions, 6 deletions
@@ -50,12 +50,6 @@ int justify(size_t linebuffer_capacity, FILE *in, FILE *out) { while ((read_word_result = read_word(in, word, MAX_WORD_LENGTH + 1)) == READ_WORD_SUCCESS) { - word_length = strlen(word); - if (word_length == 0) { - linebuffer_write(lb, out); - linebuffer_destroy(lb); - return EXIT_SUCCESS; - } if (!linebuffer_append_word(lb, word)) { linebuffer_write_justified(lb, out); linebuffer_clear(lb); diff --git a/tests/test_word.c b/tests/test_word.c index aa58a34..54dbf45 100644 --- a/tests/test_word.c +++ b/tests/test_word.c @@ -125,6 +125,24 @@ void test_read_word_empty_input(void **state) { } /** + * GIVEN an input string that is only whitespace characters + * WHEN we read a word from the file + * THEN we expect to get EOF on read + */ +void test_read_word_input_with_only_spaces(void **state) { + const char *input = " \t\t\n\n"; + const char *expected = ""; + FILE *fp = create_tmp_file(input); + char word[100]; + + int result = read_word(fp, word, sizeof(word)); + + assert_int_equal(result, READ_WORD_ERR_EOF); + assert_string_equal(word, expected); + fclose(fp); +} + +/** * GIVEN a NULL input * WHEN we read a word from the file * THEN we expect to get a read error @@ -198,6 +216,7 @@ int main(void) { cmocka_unit_test(test_read_word_trailing_spaces), cmocka_unit_test(test_read_word_multiple_spaces), cmocka_unit_test(test_read_word_empty_input), + cmocka_unit_test(test_read_word_input_with_only_spaces), cmocka_unit_test(test_read_word_null_fp), cmocka_unit_test(test_read_word_null_word), cmocka_unit_test(test_read_word_zero_length), |