aboutsummaryrefslogtreecommitdiffstats
path: root/internal/services
diff options
context:
space:
mode:
authorEugene Triguba <hello@eugenetriguba.com>2026-11-13 22:13:14 -0800
committerEugene Triguba <hello@eugenetriguba.com>2026-11-13 22:13:14 -0800
commit9656e14fc758053f34f5cb0e906093e2a18f6162 (patch)
tree3d7799305de92be6a09bcd12c29fe0843b7b8cab /internal/services
parentRemove migration dependencies (diff)
downloadcli-9656e14fc758053f34f5cb0e906093e2a18f6162.zip
Remove timestamp version style in favor of always using sequential
Diffstat (limited to 'internal/services')
-rw-r--r--internal/services/migration.go130
-rw-r--r--internal/services/migration_test.go257
2 files changed, 52 insertions, 335 deletions
diff --git a/internal/services/migration.go b/internal/services/migration.go
index ddfb8c2..a861176 100644
--- a/internal/services/migration.go
+++ b/internal/services/migration.go
@@ -6,7 +6,6 @@ import (
"strconv"
"time"
- "git.sr.ht/~eugenetriguba/bolt/internal/configloader"
"git.sr.ht/~eugenetriguba/bolt/internal/models"
"git.sr.ht/~eugenetriguba/bolt/internal/output"
"git.sr.ht/~eugenetriguba/bolt/internal/repositories"
@@ -15,20 +14,17 @@ import (
type MigrationService struct {
dbRepo repositories.MigrationDBRepo
fsRepo repositories.MigrationFsRepo
- cfg configloader.Config
outputter output.Outputter
}
func NewMigrationService(
dbRepo repositories.MigrationDBRepo,
fsRepo repositories.MigrationFsRepo,
- cfg configloader.Config,
outputter output.Outputter,
) MigrationService {
return MigrationService{
dbRepo: dbRepo,
fsRepo: fsRepo,
- cfg: cfg,
outputter: outputter,
}
}
@@ -235,19 +231,13 @@ func (ms MigrationService) RevertMigration(migration *models.Migration) error {
}
func (ms MigrationService) CreateMigration(message string) (*models.Migration, error) {
- var migration *models.Migration
-
- if ms.cfg.Migrations.VersionStyle == configloader.VersionStyleTimestamp {
- migration = models.NewTimestampMigration(time.Now(), message)
- } else {
- currentVersion, err := ms.getCurrentSequentialMigrationVersion()
- if err != nil {
- return nil, err
- }
- migration = models.NewSequentialMigration(currentVersion+1, message)
+ currentVersion, err := ms.getCurrentMigrationVersion()
+ if err != nil {
+ return nil, err
}
+ migration := models.NewMigration(currentVersion+1, message)
- err := ms.fsRepo.Create(migration)
+ err = ms.fsRepo.Create(migration)
if err != nil {
return nil, err
}
@@ -257,32 +247,37 @@ func (ms MigrationService) CreateMigration(message string) (*models.Migration, e
return migration, nil
}
-func (ms MigrationService) getCurrentSequentialMigrationVersion() (uint64, error) {
- var currentVersion uint64 = 0
+func (ms MigrationService) getCurrentMigrationVersion() (uint64, error) {
+ var maxVersion uint64 = 0
localMigrations, err := ms.fsRepo.List()
if err != nil {
return 0, fmt.Errorf("unable to list out local filesystem migrations: %w", err)
}
- migrations, err := ms.combineMigrations(
- localMigrations,
- map[string]*models.Migration{},
- SortOrderDesc,
- )
- if err != nil {
- return 0, err
- }
-
- if len(migrations) > 0 {
- latestMigration := migrations[0]
- currentVersion, err = strconv.ParseUint(latestMigration.Version, 10, 64)
+ for _, migration := range localMigrations {
+ version, err := parseVersion(migration)
if err != nil {
return 0, err
}
+ if version > maxVersion {
+ maxVersion = version
+ }
}
- return currentVersion, nil
+ return maxVersion, nil
+}
+
+func parseVersion(migration *models.Migration) (uint64, error) {
+ version, err := strconv.ParseUint(migration.Version, 10, 64)
+ if err != nil {
+ return 0, fmt.Errorf(
+ "migration %s has an invalid version: expected a number: %w",
+ migration.Name(),
+ err,
+ )
+ }
+ return version, nil
}
func (ms MigrationService) ListMigrations(order sortOrder) ([]*models.Migration, error) {
@@ -334,73 +329,20 @@ func (ms MigrationService) sortMigrations(
migrations []*models.Migration,
order sortOrder,
) error {
- sortErrs := make([]error, 0)
- sort.Slice(migrations, func(i, j int) bool {
- var comparison bool
- var err error
-
- if ms.cfg.Migrations.VersionStyle == configloader.VersionStyleSequential {
- comparison, err = ms.compareSequentialMigrations(
- migrations[i],
- migrations[j],
- order,
- )
- } else {
- comparison, err = ms.compareTimestampMigrations(migrations[i], migrations[j], order)
- }
-
+ versions := make(map[*models.Migration]uint64, len(migrations))
+ for _, migration := range migrations {
+ version, err := parseVersion(migration)
if err != nil {
- sortErrs = append(sortErrs, err)
+ return fmt.Errorf("unable to sort migrations: %w", err)
}
+ versions[migration] = version
+ }
- return comparison
+ sort.Slice(migrations, func(i, j int) bool {
+ if order == SortOrderAsc {
+ return versions[migrations[i]] < versions[migrations[j]]
+ }
+ return versions[migrations[i]] > versions[migrations[j]]
})
- if len(sortErrs) != 0 {
- return fmt.Errorf("unable to sort migrations: %v", sortErrs)
- }
return nil
}
-
-func (ms MigrationService) compareSequentialMigrations(
- m1 *models.Migration,
- m2 *models.Migration,
- order sortOrder,
-) (bool, error) {
- m1Version, err := strconv.ParseInt(m1.Version, 10, 64)
- if err != nil {
- return false, err
- }
-
- m2Version, err := strconv.ParseInt(m2.Version, 10, 64)
- if err != nil {
- return false, err
- }
-
- if order == SortOrderAsc {
- return m1Version < m2Version, nil
- } else {
- return m1Version > m2Version, nil
- }
-}
-
-func (ms MigrationService) compareTimestampMigrations(
- m1 *models.Migration,
- m2 *models.Migration,
- order sortOrder,
-) (bool, error) {
- m1Version, err := time.Parse("20060102150405", m1.Version)
- if err != nil {
- return false, err
- }
-
- m2Version, err := time.Parse("20060102150405", m2.Version)
- if err != nil {
- return false, err
- }
-
- if order == SortOrderAsc {
- return m1Version.Before(m2Version), nil
- } else {
- return m1Version.After(m2Version), nil
- }
-}
diff --git a/internal/services/migration_test.go b/internal/services/migration_test.go
index 09d33a3..0496299 100644
--- a/internal/services/migration_test.go
+++ b/internal/services/migration_test.go
@@ -3,10 +3,9 @@ package services
import (
"errors"
"testing"
- "time"
"git.sr.ht/~eugenetriguba/bolt/internal/bolttest"
- "git.sr.ht/~eugenetriguba/bolt/internal/configloader"
+
"git.sr.ht/~eugenetriguba/bolt/internal/models"
"git.sr.ht/~eugenetriguba/bolt/internal/sqlparse"
"git.sr.ht/~eugenetriguba/checkmate/assert"
@@ -17,7 +16,6 @@ func TestListMigrations(t *testing.T) {
type test struct {
localFilesystemMigrations []*models.Migration
remoteAppliedMigrations []*models.Migration
- cfg configloader.Config
sortOrder sortOrder
expectedMigrations []*models.Migration
}
@@ -27,13 +25,8 @@ func TestListMigrations(t *testing.T) {
{
localFilesystemMigrations: []*models.Migration{},
remoteAppliedMigrations: []*models.Migration{},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
- sortOrder: SortOrderAsc,
- expectedMigrations: []*models.Migration{},
+ sortOrder: SortOrderAsc,
+ expectedMigrations: []*models.Migration{},
},
// Ensure one local fs migration shows up as expected.
{
@@ -41,12 +34,7 @@ func TestListMigrations(t *testing.T) {
{Version: "001", Applied: false},
},
remoteAppliedMigrations: []*models.Migration{},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
- sortOrder: SortOrderAsc,
+ sortOrder: SortOrderAsc,
expectedMigrations: []*models.Migration{
{Version: "001", Applied: false},
},
@@ -60,11 +48,6 @@ func TestListMigrations(t *testing.T) {
remoteAppliedMigrations: []*models.Migration{
{Version: "001", Applied: true},
},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
sortOrder: SortOrderAsc,
expectedMigrations: []*models.Migration{
{Version: "001", Applied: true},
@@ -77,11 +60,6 @@ func TestListMigrations(t *testing.T) {
remoteAppliedMigrations: []*models.Migration{
{Version: "001", Applied: true},
},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
sortOrder: SortOrderAsc,
expectedMigrations: []*models.Migration{},
},
@@ -97,12 +75,7 @@ func TestListMigrations(t *testing.T) {
{Version: "001"},
},
remoteAppliedMigrations: []*models.Migration{},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
- sortOrder: SortOrderAsc,
+ sortOrder: SortOrderAsc,
expectedMigrations: []*models.Migration{
{Version: "001"},
{Version: "110"},
@@ -125,12 +98,7 @@ func TestListMigrations(t *testing.T) {
{Version: "20000"},
},
remoteAppliedMigrations: []*models.Migration{},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
- sortOrder: SortOrderDesc,
+ sortOrder: SortOrderDesc,
expectedMigrations: []*models.Migration{
{Version: "20000"},
{Version: "10000"},
@@ -141,62 +109,6 @@ func TestListMigrations(t *testing.T) {
{Version: "001"},
},
},
- // Ensure that migrations are sorted in asc order for timestamp migrations
- {
- localFilesystemMigrations: []*models.Migration{
- {Version: "20080509220905"},
- {Version: "20080509220405"},
- {Version: "20080509150405"},
- {Version: "20080502150405"},
- {Version: "20080102150405"},
- {Version: "20070102150405"},
- {Version: "20060102150405"},
- },
- remoteAppliedMigrations: []*models.Migration{},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleTimestamp,
- },
- },
- sortOrder: SortOrderAsc,
- expectedMigrations: []*models.Migration{
- {Version: "20060102150405"},
- {Version: "20070102150405"},
- {Version: "20080102150405"},
- {Version: "20080502150405"},
- {Version: "20080509150405"},
- {Version: "20080509220405"},
- {Version: "20080509220905"},
- },
- },
- // Ensure that migrations are sorted in desc order for timestamp migrations
- {
- localFilesystemMigrations: []*models.Migration{
- {Version: "20060102150405"},
- {Version: "20070102150405"},
- {Version: "20080102150405"},
- {Version: "20080502150405"},
- {Version: "20080509150405"},
- {Version: "20080509220405"},
- {Version: "20080509220905"},
- },
- remoteAppliedMigrations: []*models.Migration{},
- cfg: configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleTimestamp,
- },
- },
- sortOrder: SortOrderDesc,
- expectedMigrations: []*models.Migration{
- {Version: "20080509220905"},
- {Version: "20080509220405"},
- {Version: "20080509150405"},
- {Version: "20080502150405"},
- {Version: "20080102150405"},
- {Version: "20070102150405"},
- {Version: "20060102150405"},
- },
- },
}
for _, tc := range tests {
@@ -225,7 +137,6 @@ func TestListMigrations(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- tc.cfg,
bolttest.NullOutputter{},
)
migrations, err := svc.ListMigrations(tc.sortOrder)
@@ -253,7 +164,6 @@ func TestListMigrations_FsRepoListError(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
migrations, err := svc.ListMigrations(SortOrderAsc)
@@ -281,7 +191,6 @@ func TestListMigrations_DbRepoListError(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
migrations, err := svc.ListMigrations(SortOrderAsc)
@@ -293,31 +202,18 @@ func TestListMigrations_DbRepoListError(t *testing.T) {
func TestListMigrations_ParseErrDuringSort(t *testing.T) {
type test struct {
- m1 models.Migration
- m2 models.Migration
- versionStyle configloader.VersionStyle
+ m1 models.Migration
+ m2 models.Migration
}
tests := []test{
{
- m1: models.Migration{Version: "abc"},
- m2: models.Migration{Version: "123"},
- versionStyle: configloader.VersionStyleSequential,
- },
- {
- m1: models.Migration{Version: "123"},
- m2: models.Migration{Version: "abc"},
- versionStyle: configloader.VersionStyleSequential,
- },
- {
- m1: models.Migration{Version: "20060102150405"},
- m2: models.Migration{Version: "abc"},
- versionStyle: configloader.VersionStyleTimestamp,
+ m1: models.Migration{Version: "abc"},
+ m2: models.Migration{Version: "123"},
},
{
- m1: models.Migration{Version: "abc"},
- m2: models.Migration{Version: "20060102150405"},
- versionStyle: configloader.VersionStyleTimestamp,
+ m1: models.Migration{Version: "123"},
+ m2: models.Migration{Version: "abc"},
},
}
@@ -341,11 +237,6 @@ func TestListMigrations_ParseErrDuringSort(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: tc.versionStyle,
- },
- },
bolttest.NullOutputter{},
)
migrations, err := svc.ListMigrations(SortOrderAsc)
@@ -356,38 +247,7 @@ func TestListMigrations_ParseErrDuringSort(t *testing.T) {
}
}
-func TestCreateMigration_VersionStyleTimestamp(t *testing.T) {
- migrationFsRepo := &bolttest.MockMigrationFsRepo{
- CreateReturnValue: bolttest.CreateReturnValue{
- Err: nil,
- },
- }
- migrationDbRepo := &bolttest.MockMigrationDBRepo{}
- svc := NewMigrationService(
- migrationDbRepo,
- migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleTimestamp,
- },
- },
- bolttest.NullOutputter{},
- )
-
- beforeCreateTs := time.Now().Add(30 * -time.Second)
- migration, err := svc.CreateMigration("new migration")
- afterCreateTs := time.Now().Add(30 * time.Second)
-
- assert.Nil(t, err)
- version, err := time.ParseInLocation("20060102150405", migration.Version, time.Local)
- assert.Nil(t, err)
- check.True(t, beforeCreateTs.Before(version))
- check.True(t, afterCreateTs.After(version))
- check.Equal(t, migration.Message, "new migration")
- check.Equal(t, migration.Applied, false)
-}
-
-func TestCreateMigration_VersionStyleSequential(t *testing.T) {
+func TestCreateMigration(t *testing.T) {
migrationFsRepo := &bolttest.MockMigrationFsRepo{
CreateReturnValue: bolttest.CreateReturnValue{
Err: nil,
@@ -397,11 +257,6 @@ func TestCreateMigration_VersionStyleSequential(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -422,11 +277,6 @@ func TestCreateMigration_NilDbRepo(t *testing.T) {
svc := NewMigrationService(
nil,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -449,11 +299,6 @@ func TestCreateMigration_CreateErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -474,11 +319,6 @@ func TestCreateMigration_LatestErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -488,7 +328,7 @@ func TestCreateMigration_LatestErr(t *testing.T) {
assert.Nil(t, migration)
}
-func TestCreateMigration_SequentialVersionIncrements(t *testing.T) {
+func TestCreateMigration_VersionIncrements(t *testing.T) {
migrationFsRepo := &bolttest.MockMigrationFsRepo{
ListReturnValue: bolttest.ListReturnValue{
Migrations: map[string]*models.Migration{
@@ -504,11 +344,6 @@ func TestCreateMigration_SequentialVersionIncrements(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -518,7 +353,7 @@ func TestCreateMigration_SequentialVersionIncrements(t *testing.T) {
assert.Equal(t, migration.Version, "002")
}
-func TestCreateMigration_SequentialVersionIncrementsLatestVersion(t *testing.T) {
+func TestCreateMigration_VersionIncrementsLatestVersion(t *testing.T) {
migrationFsRepo := &bolttest.MockMigrationFsRepo{
ListReturnValue: bolttest.ListReturnValue{
Migrations: map[string]*models.Migration{
@@ -536,11 +371,6 @@ func TestCreateMigration_SequentialVersionIncrementsLatestVersion(t *testing.T)
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -550,7 +380,7 @@ func TestCreateMigration_SequentialVersionIncrementsLatestVersion(t *testing.T)
assert.Equal(t, migration.Version, "004")
}
-func TestCreateMigration_SequentialVersionIncrementsParsingErr(t *testing.T) {
+func TestCreateMigration_VersionIncrementsParsingErr(t *testing.T) {
migrationFsRepo := &bolttest.MockMigrationFsRepo{
ListReturnValue: bolttest.ListReturnValue{
Migrations: map[string]*models.Migration{
@@ -566,11 +396,6 @@ func TestCreateMigration_SequentialVersionIncrementsParsingErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -599,7 +424,6 @@ func TestApplyMigration_WithTransaction(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -629,7 +453,6 @@ func TestApplyMigration_WithoutTransaction(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -653,7 +476,6 @@ func TestApplyMigration_ReadUpgradeScriptErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -680,7 +502,6 @@ func TestApplyMigration_ApplyWithTxErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -707,7 +528,6 @@ func TestApplyMigration_ApplyErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -727,7 +547,6 @@ func TestApplyAllMigrations_ListMigrationsErr(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -751,11 +570,6 @@ func TestApplyAllMigrations_AppliesNothingIfAllApplied(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -784,11 +598,6 @@ func TestApplyAllMigrations_ApplyMigrationErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -810,7 +619,6 @@ func TestApplyUpToVersion_ListMigrationsErr(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -832,7 +640,6 @@ func TestApplyUpToVersion_TargetMigrationNotFound(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -854,7 +661,6 @@ func TestApplyUpToVersion_TargetMigrationAlreadyApplied(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -880,7 +686,6 @@ func TestApplyUpToVersion_ApplyMigrationErr(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -904,11 +709,6 @@ func TestApplyUpToVersion_AppliesMigrations(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -937,7 +737,6 @@ func TestRevertMigration_WithTransaction(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -966,7 +765,6 @@ func TestRevertMigration_WithoutTransaction(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -989,7 +787,6 @@ func TestRevertMigration_ReadUpgradeScriptErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1016,7 +813,6 @@ func TestRevertMigration_RevertWithTxErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1043,7 +839,6 @@ func TestRevertMigration_RevertErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1063,7 +858,6 @@ func TestRevertDownToVersion_ListMigrationsErr(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1085,7 +879,6 @@ func TestRevertDownToVersion_TargetMigrationNotFound(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1107,7 +900,6 @@ func TestRevertDownToVersion_TargetMigrationNotApplied(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1133,7 +925,6 @@ func TestRevertDownToVersion_RevertMigrationErr(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1157,11 +948,6 @@ func TestRevertDownToVersion_RevertsMigrations(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -1182,7 +968,6 @@ func TestRevertAllMigrations_ListMigrationsErr(t *testing.T) {
svc := NewMigrationService(
&bolttest.MockMigrationDBRepo{},
migrationFsRepo,
- configloader.Config{},
bolttest.NullOutputter{},
)
@@ -1206,11 +991,6 @@ func TestRevertAllMigrations_RevertsNothingIfNoneApplied(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)
@@ -1239,11 +1019,6 @@ func TestRevertAllMigrations_RevertMigrationErr(t *testing.T) {
svc := NewMigrationService(
migrationDbRepo,
migrationFsRepo,
- configloader.Config{
- Migrations: configloader.MigrationsConfig{
- VersionStyle: configloader.VersionStyleSequential,
- },
- },
bolttest.NullOutputter{},
)